From ff6bfe387d472c35d26fc65d6a1c5f2b8f04d799 Mon Sep 17 00:00:00 2001 From: epriestley Date: Sat, 9 Jan 2016 13:46:28 -0800 Subject: [PATCH] Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height` Summary: Ref T10110. If an image had `width` or `height`, we would accidentally not give it an `$image_class`. Test Plan: {F1057988} {F1057989} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10110 Differential Revision: https://secure.phabricator.com/D14983 --- .../files/markup/PhabricatorEmbedFileRemarkupRule.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php b/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php index 138465a633..7f57db02b1 100644 --- a/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php +++ b/src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php @@ -79,7 +79,7 @@ final class PhabricatorEmbedFileRemarkupRule require_celerity_resource('lightbox-attachment-css'); $attrs = array(); - $image_class = null; + $image_class = 'phabricator-remarkup-embed-image'; $use_size = true; if (!$options['size']) { @@ -117,8 +117,6 @@ final class PhabricatorEmbedFileRemarkupRule $attrs['width'] = $x; $attrs['height'] = $y; } - - $image_class = 'phabricator-remarkup-embed-image'; break; } }