From ff7a514af38c7390704ef59aafa9bbb6bd270345 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Thu, 20 Nov 2014 17:05:32 -0800
Subject: [PATCH] Minor, increase spacing on buttons

Summary: Increase space, other visual polish

Test Plan: Check UIExamples on buttons and button bar. View policy controls.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D10886
---
 resources/celerity/map.php            |  6 +++---
 webroot/rsrc/css/phui/phui-button.css | 27 ++++++++++-----------------
 2 files changed, 13 insertions(+), 20 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 19d3fa6fa6..cd14faf8af 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '673d0a25',
+    'core.pkg.css' => '16b54ea0',
     'core.pkg.js' => 'e5f7f2ba',
     'darkconsole.pkg.js' => 'df001cab',
     'differential.pkg.css' => '8af45893',
@@ -122,7 +122,7 @@ return array(
     'rsrc/css/phui/phui-action-header-view.css' => '89c497e7',
     'rsrc/css/phui/phui-action-list.css' => '9ee9910a',
     'rsrc/css/phui/phui-box.css' => '7b3a2eed',
-    'rsrc/css/phui/phui-button.css' => 'c7412aa1',
+    'rsrc/css/phui/phui-button.css' => 'd5fe9ce8',
     'rsrc/css/phui/phui-document.css' => 'a5615198',
     'rsrc/css/phui/phui-feed-story.css' => 'dd3c5ff5',
     'rsrc/css/phui/phui-fontkit.css' => '9c3d2dce',
@@ -766,7 +766,7 @@ return array(
     'phriction-document-css' => '7d7f0071',
     'phui-action-header-view-css' => '89c497e7',
     'phui-box-css' => '7b3a2eed',
-    'phui-button-css' => 'c7412aa1',
+    'phui-button-css' => 'd5fe9ce8',
     'phui-calendar-css' => '8675968e',
     'phui-calendar-day-css' => 'de035c8a',
     'phui-calendar-list-css' => 'c1d0ca59',
diff --git a/webroot/rsrc/css/phui/phui-button.css b/webroot/rsrc/css/phui/phui-button.css
index f7998dd3bb..4270f589c0 100644
--- a/webroot/rsrc/css/phui/phui-button.css
+++ b/webroot/rsrc/css/phui/phui-button.css
@@ -6,6 +6,11 @@
 button,
 a.button {
   font: 13px/1.231 'Helvetica Neue', Helvetica, Arial, sans-serif;
+  -webkit-font-smoothing: antialiased;
+  -webkit-user-select: none;
+  -moz-user-select: none;
+  -ms-user-select: none;
+  user-select: none;
 }
 
 button,
@@ -14,13 +19,12 @@ a.button:visited,
 input[type="submit"] {
   background-color: #3477ad;
   color: white;
-  text-shadow: 0 -1px rgba(0,0,0,0.75);
   border: 1px solid #19558D;
   cursor: pointer;
   font-weight: bold;
   font-size: 13px;
   display: inline-block;
-  padding: 3px 10px 4px;
+  padding: 3px 12px 4px;
   text-align: center;
   white-space: nowrap;
   border-radius: 3px;
@@ -67,7 +71,6 @@ a.grey:visited {
   border-color: {$lightgreyborder};
   color: {$darkgreytext};
   border-bottom-color: {$greyborder};
-  text-shadow: none;
 }
 
 button.simple,
@@ -79,7 +82,6 @@ a.simple:visited {
   border: 1px solid transparent;
   color: {$bluetext};
   border: 1px solid {$lightblueborder};
-  text-shadow: 0 1px #fff;
 }
 
 a.disabled,
@@ -120,7 +122,6 @@ button.simple:hover {
   border: 1px solid {$lightgreyborder};
   background-image: none;
   border-bottom: 1px solid {$greyborder};
-  text-shadow: none;
   box-shadow: none;
 }
 
@@ -145,7 +146,7 @@ body button.disabled:active {
 button.small,
 a.small,
 a.small:visited {
-  padding: 2px 7px;
+  padding: 2px 8px;
   height: auto;
   font-size: 11px;
   line-height: 16px;
@@ -161,7 +162,6 @@ button.link {
   font-size: inherit;
   border-bottom: none;
   text-decoration: none;
-  text-shadow: none;
   color: #19558D;
   -webkit-box-shadow: none;
   -moz-box-shadow: none;
@@ -200,13 +200,6 @@ a.policy-control .caret {
   float: right;
 }
 
-a.policy-control span.phui-icon-view {
-  /* NOTE: Nudge these icons a little bit. Should this be for all
-     dropdown buttons? */
-  top: 4px;
-  left: 7px;
-}
-
 a.toggle {
   display: inline-block;
   padding: 4px 8px;
@@ -293,11 +286,11 @@ a.toggle-fixed {
   display: inline-block;
   position: absolute;
   top: 5px;
-  left: 8px;
+  left: 10px;
 }
 
 .phui-button-bar .button .phui-icon-view {
-  left: 11px;
+  left: 12px;
 }
 
 .button.has-icon .phui-button-text {
@@ -313,7 +306,7 @@ a.toggle-fixed {
 }
 
 .button.big.has-icon .phui-button-text {
-  margin-left: 36px;
+  margin-left: 40px;
   font-size: 14px;
   display: block;
 }