revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-19 16:58:48 +02:00
Code Issues Releases Wiki Activity

Fix white + icon hover / apps create

Browse source 
Summary: Decided to just remove the hover grey to white, seems fine with the new white icons.

Test Plan: use homepage + icons

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6181
This commit is contained in:
Chad Little 2013-06-11 19:10:12 -07:00
parent 4c9c6fcda8
commit ff89843034
5 changed files with 50 additions and 55 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/sprite/manifest/icons.json
View file

@ -688,7 +688,7 @@
},
"icons-new-white" : {
"name" : "icons-new-white",
"rule" : ".icons-new-white, .device-desktop .phabricator-action-view:hover .icons-new, .device-desktop .phui-list-sidenav .phui-list-item-href:hover .icons-new, .phabricator-application-launch-create:hover .phabricator-application-create-icon.icons-new-grey",
"rule" : ".icons-new-white, .device-desktop .phabricator-action-view:hover .icons-new, .device-desktop .phui-list-sidenav .phui-list-item-href:hover .icons-new",
"hash" : "58d004330176465bf3f0ffe1fa5dea29"
},
"icons-none" : {

94
src/__celerity_resource_map__.php
View file

@ -1325,7 +1325,7 @@ celerity_register_resource_map(array(
),
'javelin-behavior-conpherence-pontificate' =>
array(
'uri' => '/res/d596e5c2/rsrc/js/application/conpherence/behavior-pontificate.js',
'uri' => '/res/19cb581b/rsrc/js/application/conpherence/behavior-pontificate.js',
'type' => 'js',
'requires' =>
array(
@ -1339,7 +1339,7 @@ celerity_register_resource_map(array(
),
'javelin-behavior-conpherence-widget-pane' =>
array(
'uri' => '/res/440f5bdf/rsrc/js/application/conpherence/behavior-widget-pane.js',
'uri' => '/res/562ca20e/rsrc/js/application/conpherence/behavior-widget-pane.js',
'type' => 'js',
'requires' =>
array(
@ -3975,7 +3975,7 @@ celerity_register_resource_map(array(
),
'sprite-icons-css' =>
array(
'uri' => '/res/da6e8b74/rsrc/css/sprite-icons.css',
'uri' => '/res/03295fbd/rsrc/css/sprite-icons.css',
'type' => 'css',
'requires' =>
array(
@ -4048,7 +4048,7 @@ celerity_register_resource_map(array(
), array(
'packages' =>
array(
'236adaa0' =>
'927f8f60' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@ -4096,7 +4096,7 @@ celerity_register_resource_map(array(
40 => 'phabricator-property-list-view-css',
41 => 'phabricator-tag-view-css',
),
'uri' => '/res/pkg/236adaa0/core.pkg.css',
'uri' => '/res/pkg/927f8f60/core.pkg.css',
'type' => 'css',
),
'f2ad0683' =>
@ -4290,16 +4290,16 @@ celerity_register_resource_map(array(
'reverse' =>
array(
'aphront-attached-file-view-css' => 'a7ca34a9',
'aphront-dialog-view-css' => '236adaa0',
'aphront-error-view-css' => '236adaa0',
'aphront-form-view-css' => '236adaa0',
'aphront-list-filter-view-css' => '236adaa0',
'aphront-pager-view-css' => '236adaa0',
'aphront-panel-view-css' => '236adaa0',
'aphront-table-view-css' => '236adaa0',
'aphront-tokenizer-control-css' => '236adaa0',
'aphront-tooltip-css' => '236adaa0',
'aphront-typeahead-control-css' => '236adaa0',
'aphront-dialog-view-css' => '927f8f60',
'aphront-error-view-css' => '927f8f60',
'aphront-form-view-css' => '927f8f60',
'aphront-list-filter-view-css' => '927f8f60',
'aphront-pager-view-css' => '927f8f60',
'aphront-panel-view-css' => '927f8f60',
'aphront-table-view-css' => '927f8f60',
'aphront-tokenizer-control-css' => '927f8f60',
'aphront-tooltip-css' => '927f8f60',
'aphront-typeahead-control-css' => '927f8f60',
'differential-changeset-view-css' => 'dd27a69b',
'differential-core-view-css' => 'dd27a69b',
'differential-inline-comment-editor' => '9488bb69',
@ -4313,7 +4313,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => 'dd27a69b',
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => '236adaa0',
'global-drag-and-drop-css' => '927f8f60',
'inline-comment-summary-css' => 'dd27a69b',
'javelin-aphlict' => 'f2ad0683',
'javelin-behavior' => 'a9f14d76',
@ -4387,55 +4387,55 @@ celerity_register_resource_map(array(
'javelin-util' => 'a9f14d76',
'javelin-vector' => 'a9f14d76',
'javelin-workflow' => 'a9f14d76',
'lightbox-attachment-css' => '236adaa0',
'lightbox-attachment-css' => '927f8f60',
'maniphest-task-summary-css' => 'a7ca34a9',
'maniphest-transaction-detail-css' => 'a7ca34a9',
'phabricator-action-list-view-css' => '236adaa0',
'phabricator-application-launch-view-css' => '236adaa0',
'phabricator-action-list-view-css' => '927f8f60',
'phabricator-application-launch-view-css' => '927f8f60',
'phabricator-busy' => 'f2ad0683',
'phabricator-content-source-view-css' => 'dd27a69b',
'phabricator-core-buttons-css' => '236adaa0',
'phabricator-core-css' => '236adaa0',
'phabricator-crumbs-view-css' => '236adaa0',
'phabricator-core-buttons-css' => '927f8f60',
'phabricator-core-css' => '927f8f60',
'phabricator-crumbs-view-css' => '927f8f60',
'phabricator-drag-and-drop-file-upload' => '9488bb69',
'phabricator-dropdown-menu' => 'f2ad0683',
'phabricator-file-upload' => 'f2ad0683',
'phabricator-filetree-view-css' => '236adaa0',
'phabricator-flag-css' => '236adaa0',
'phabricator-form-view-css' => '236adaa0',
'phabricator-header-view-css' => '236adaa0',
'phabricator-filetree-view-css' => '927f8f60',
'phabricator-flag-css' => '927f8f60',
'phabricator-form-view-css' => '927f8f60',
'phabricator-header-view-css' => '927f8f60',
'phabricator-hovercard' => 'f2ad0683',
'phabricator-jump-nav' => '236adaa0',
'phabricator-jump-nav' => '927f8f60',
'phabricator-keyboard-shortcut' => 'f2ad0683',
'phabricator-keyboard-shortcut-manager' => 'f2ad0683',
'phabricator-main-menu-view' => '236adaa0',
'phabricator-main-menu-view' => '927f8f60',
'phabricator-menu-item' => 'f2ad0683',
'phabricator-nav-view-css' => '236adaa0',
'phabricator-nav-view-css' => '927f8f60',
'phabricator-notification' => 'f2ad0683',
'phabricator-notification-css' => '236adaa0',
'phabricator-notification-menu-css' => '236adaa0',
'phabricator-object-item-list-view-css' => '236adaa0',
'phabricator-notification-css' => '927f8f60',
'phabricator-notification-menu-css' => '927f8f60',
'phabricator-object-item-list-view-css' => '927f8f60',
'phabricator-object-selector-css' => 'dd27a69b',
'phabricator-phtize' => 'f2ad0683',
'phabricator-prefab' => 'f2ad0683',
'phabricator-project-tag-css' => 'a7ca34a9',
'phabricator-property-list-view-css' => '236adaa0',
'phabricator-remarkup-css' => '236adaa0',
'phabricator-property-list-view-css' => '927f8f60',
'phabricator-remarkup-css' => '927f8f60',
'phabricator-shaped-request' => '9488bb69',
'phabricator-side-menu-view-css' => '236adaa0',
'phabricator-standard-page-view' => '236adaa0',
'phabricator-tag-view-css' => '236adaa0',
'phabricator-side-menu-view-css' => '927f8f60',
'phabricator-standard-page-view' => '927f8f60',
'phabricator-tag-view-css' => '927f8f60',
'phabricator-textareautils' => 'f2ad0683',
'phabricator-tooltip' => 'f2ad0683',
'phabricator-transaction-view-css' => '236adaa0',
'phabricator-zindex-css' => '236adaa0',
'phui-form-css' => '236adaa0',
'phui-icon-view-css' => '236adaa0',
'spacing-css' => '236adaa0',
'sprite-apps-large-css' => '236adaa0',
'sprite-gradient-css' => '236adaa0',
'sprite-icons-css' => '236adaa0',
'sprite-menu-css' => '236adaa0',
'syntax-highlighting-css' => '236adaa0',
'phabricator-transaction-view-css' => '927f8f60',
'phabricator-zindex-css' => '927f8f60',
'phui-form-css' => '927f8f60',
'phui-icon-view-css' => '927f8f60',
'spacing-css' => '927f8f60',
'sprite-apps-large-css' => '927f8f60',
'sprite-gradient-css' => '927f8f60',
'sprite-icons-css' => '927f8f60',
'sprite-menu-css' => '927f8f60',
'syntax-highlighting-css' => '927f8f60',
),
));

2
src/applications/meta/view/PhabricatorApplicationLaunchView.php
View file

@ -130,7 +130,7 @@ final class PhabricatorApplicationLaunchView extends AphrontView {
if ($application->getQuickCreateURI()) {
$classes[] = 'phabricator-application-create-icon';
$classes[] = 'sprite-icons';
$classes[] = 'icons-new-grey';
$classes[] = 'icons-new-white';
$plus_icon = phutil_tag(
'span',
array(

5
src/infrastructure/celerity/CeleritySpriteGenerator.php
View file

@ -42,11 +42,6 @@ final class CeleritySpriteGenerator {
'.icons-'.$icon;
$tcss[] = '.device-desktop .phui-list-sidenav '.
'.phui-list-item-href:hover .icons-'.$icon;
if ($icon == 'new') {
// Hover state for the "+" icons on homepage tiles.
$tcss[] = '.phabricator-application-launch-create:hover '.
'.phabricator-application-create-icon.icons-new-grey';
}
}
$sprite->setTargetCSS(implode(', ', $tcss));

2
webroot/rsrc/css/sprite-icons.css
View file

@ -694,7 +694,7 @@ only screen and (-webkit-min-device-pixel-ratio: 1.5) {
background-position: 0px -180px;
}
.icons-new-white, .device-desktop .phabricator-action-view:hover .icons-new, .device-desktop .phui-list-sidenav .phui-list-item-href:hover .icons-new, .phabricator-application-launch-create:hover .phabricator-application-create-icon.icons-new-grey {
.icons-new-white, .device-desktop .phabricator-action-view:hover .icons-new, .device-desktop .phui-list-sidenav .phui-list-item-href:hover .icons-new {
background-position: -15px -180px;
}