mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Fix an issue where email for "accepted" revisions would fatal
Summary: When trying to render "BRANCH", we need the active diff. Load it in general since it seems reasonable for custom fields to expect it to exist during mail rendering.
This commit is contained in:
parent
750a30d441
commit
ff98565db6
1 changed files with 2 additions and 0 deletions
|
@ -587,6 +587,7 @@ final class DifferentialTransactionEditor
|
|||
$new_revision = id(new DifferentialRevisionQuery())
|
||||
->setViewer($this->getActor())
|
||||
->needReviewerStatus(true)
|
||||
->needActiveDiffs(true)
|
||||
->withIDs(array($object->getID()))
|
||||
->executeOne();
|
||||
if (!$new_revision) {
|
||||
|
@ -595,6 +596,7 @@ final class DifferentialTransactionEditor
|
|||
}
|
||||
|
||||
$object->attachReviewerStatus($new_revision->getReviewerStatus());
|
||||
$object->attachActiveDiff($new_revision->getActiveDiff());
|
||||
|
||||
foreach ($xactions as $xaction) {
|
||||
switch ($xaction->getTransactionType()) {
|
||||
|
|
Loading…
Reference in a new issue