From ffae7b19e69fb7d0e44340cb8739c35ab3a7a41b Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 21 Jul 2011 16:26:51 -0700 Subject: [PATCH] Slightly loosen the mention regexp to allow for "Go ask @tomo." Summary: Currently, we incorrectly flag these under the "@lists.com" rule. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-887c2bc66eb9d47d02f4/ Reviewed By: tomo Reviewers: tomo CC: aran, epriestley, tomo Differential Revision: 708 --- .../markuprule/mention/PhabricatorRemarkupRuleMention.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php b/src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php index be1b59f83a..86b7065edb 100644 --- a/src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php +++ b/src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php @@ -29,8 +29,9 @@ class PhabricatorRemarkupRuleMention // NOTE: Negative lookahead for period prevents us from picking up email // addresses, while allowing constructs like "@tomo, lol". The negative // lookbehind for a word character prevents us from matching "mail@lists" - // while allowing "@tomo/@mroch". - $regexp = '/(?