Allow emails to be used for login

Summary:
Despite the form's claims that you can login with username or email, it actually
accepted only username.

Test Plan:
Logged in using my email.

Reviewed By: jungejason
Reviewers: tuomaspelkonen, jungejason, aran
CC: jr, anjali, aran, jungejason
Differential Revision: 354

src/applications/auth/controller/login/PhabricatorLoginController.php

@@ -44,11 +44,17 @@ class PhabricatorLoginController extends PhabricatorAuthController {
       $error = false;
       $username = $request->getCookie('phusr');
       if ($request->isFormPost()) {
-        $username = $request->getStr('username');
+        $username_or_email = $request->getStr('username_or_email');
 
         $user = id(new PhabricatorUser())->loadOneWhere(
           'username = %s',
-          $username);
+          $username_or_email);
+
+        if (!$user) {
+          $user = id(new PhabricatorUser())->loadOneWhere(
+            'email = %s',
+            $username_or_email);
+        }
 
         $okay = false;
         if ($user) {
@@ -91,8 +97,8 @@ class PhabricatorLoginController extends PhabricatorAuthController {
         ->appendChild(
           id(new AphrontFormTextControl())
             ->setLabel('Username/Email')
-            ->setName('username')
+            ->setName('username_or_email')
-            ->setValue($username))
+            ->setValue($username_or_email))
         ->appendChild(
           id(new AphrontFormPasswordControl())
             ->setLabel('Password')