3 commits

Author	SHA1	Message	Date
epriestley	09c8af4de0	Upgrade phabricator to libphutil v2 ... Summary: Mechanical changes from D2588. No "Class.php" moves yet. Test Plan: See D2588. Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1103 Differential Revision: https://secure.phabricator.com/D2591	2012-05-30 14:26:29 -07:00
vrana	5e58a016a5	Allow full anchors in remarkup object names ... Summary: Remarkup object names require #1 for linking to comments which is not very intuitive. Test Plan: D1558#4e01328c D1558#1 D1558#comment-1 Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1565	2012-02-03 15:50:19 -08:00
epriestley	d96d515cc2	Add comment linking to Maniphest and Differential ... Summary: Allows you to link to comments with "D123#3" or "T123#3", then adds a pile of JS to try to make it not terrible. :/ The thing I'm trying to avoid here is when someone says "look at this! http://blog.com/#comment-239291" and you click and your browser jumps somewhere random and you have no idea which comment they meant. Since I really hate this, I've tried to avoid it by making sure the comment is always highlighted. Test Plan: Put T1#1 and D1#1 in remarkup and verified they linked properly. Clicked anchors on individual comments. Faked all comments hidden in Differential and verified they expanded on anchor or anchor change. Reviewed By: aran Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 383	2011-05-31 11:11:19 -07:00