4 commits

Author	SHA1	Message	Date
epriestley	2a37459a5f	Only resolve branch names to branches ... Summary: Fixes T7100. In the bizarre case that a Git repository has a branch and tag with the same name, don't resolve branch names into tag names. Test Plan: Test repo with branch and tag both named "git" no longer reports ambiguity. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T7100 Differential Revision: https://secure.phabricator.com/D12553	2015-04-27 03:51:53 -07:00
epriestley	156b156e77	Give Conduit params/return/errors protected visibility ... Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380	2015-04-13 11:58:35 -07:00
epriestley	20589389de	Fix some issues with new Conduit method implementations ... Summary: Ref T5655. A few of these were missed. Test Plan: Checked all other methods like this: ``` foreach ($method_map as $k => $v) { $v = preg_replace('/ConduitAPIMethod$/', '', $v); $k = str_replace('.', '', $k); $v = strtolower($v); if ($k != $v) { echo "{$k} x {$v}!\n"; } } echo "OK\n"; ``` Reviewers: hach-que, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T5655 Differential Revision: https://secure.phabricator.com/D10049	2014-07-24 21:57:03 -07:00
Joshua Spence	023dee0d3b	Rename Conduit classes ... Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method. Test Plan: ``` > echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami Waiting for JSON parameters on stdin... {"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}} ``` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin, hach-que Maniphest Tasks: T5655 Differential Revision: https://secure.phabricator.com/D9991	2014-07-25 10:54:15 +10:00

Renamed from src/applications/diffusion/conduit/ConduitAPI_diffusion_resolverefs_Method.php (Browse further)