4 commits

Author	SHA1	Message	Date
vrana	6472dbe168	Change fileName to filename ... Summary: There are lots of callsites to $changeset->getFilename() so it seemed easier to rename getFileName() to getFilename() even if it includes database change. Plus I think that getFilename() is better. Test Plan: Alter database. Open revision. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1437	2012-01-17 10:50:14 -08:00
vrana	8bed2f4387	Utilize phutil_render_tag() ... Test Plan: Display diff with lint error. Reviewers: pad, epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1428	2012-01-16 17:08:21 -08:00
vrana	c6febdfc52	Add link from lint error to code ... Test Plan: Display diff with lint errors Click on a line number in lint errors overview Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1400	2012-01-14 11:11:17 -08:00
epriestley	442d1dbeaa	Move Differential's remaining field views to extensble field schema ... Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809	2011-08-15 10:20:46 -07:00