10 commits

Author	SHA1	Message	Date
epriestley	3ab334af93	Fix "reply" link in Differential ... Summary: Fixes the issue caused by rPa0af5b66437719dba6136579c051982ab275e6a0. Prior to that patch, isCommentInNewFile() returned $comment->getIsNewFile(). While this was often the wrong value, it came from the database and was the integer 1 if true. After the patch, the function returns 'true' as a boolean, which is passed to JS and then back to PHP, interpreted as an integer, and evaluates to 0. To avoid this issue in general, provide an isBool() method on AphrontRequest which interprets this correctly. I will also revert the revert of rPa0af5b66437719dba6136579c051982ab275e6a0 when I land this. Test Plan: Clicked "reply" on the right hand side of a diff, got a right-hand-side inline comment. Reviewed By: rm Reviewers: tuomaspelkonen, jungejason, aran, rm CC: simpkins, aran, epriestley, rm Differential Revision: 250	2011-05-08 21:23:15 -07:00
epriestley	605268f9aa	Some acutal conduit authentication.	2011-02-05 22:36:21 -08:00
epriestley	50bfcd0a30	100-changeset cutoff.	2011-02-05 16:43:28 -08:00
epriestley	de2a9c634c	Differential lazyweb diff create workflow.	2011-02-05 12:20:18 -08:00
epriestley	759eec3a77	Very rough cut of DarkConsole + XHProf	2011-02-02 13:48:52 -08:00
epriestley	03fec6e911	PhabricatorEnv ... 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset	2011-01-31 11:55:26 -08:00
epriestley	29f7219a49	CSRF / Logout	2011-01-30 18:52:29 -08:00
epriestley	ccf7df6093	Authentication	2011-01-26 15:34:20 -08:00
epriestley	bc57b12ef0	MetaMTA	2011-01-26 08:00:52 -08:00
epriestley	76258ce0e1	Import some code, some of which may be relevant to the project.	2011-01-17 19:31:39 -08:00