3 commits

Author	SHA1	Message	Date
epriestley	59c294457f	Modularize more Herald fields ... Summary: Ref T8726. Continue making Herald fields more modular than they currently are. Test Plan: - Created a rule using all the affected fields. - Ran the rule. - Saw reasonable object field values. Reviewers: btrahan Reviewed By: btrahan Subscribers: eadler, joshuaspence, epriestley Maniphest Tasks: T8726 Differential Revision: https://secure.phabricator.com/D13495	2015-07-06 13:15:47 -07:00
Joshua Spence	36e2d02d6e	phtize all the things ... Summary: `pht`ize a whole bunch of strings in rP. Test Plan: Intense eyeballing. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: hach-que, Korvin, epriestley Differential Revision: https://secure.phabricator.com/D12797	2015-05-22 21:16:39 +10:00
Bob Trahan	1830868007	Herald - make herald condition of herald rule display better ... Summary: ...by the surprising step of changing how this data is stored from id to phid. Also a small fix to not allow "disabled" rules to be used as herald rule conditions, i.e. can't make a rule that depends on a disabled rule. Test Plan: viewed existing herald rule that had a rule condition and noted nice new display using handle. made a new rule that had a rule condition and verified it worked correctly. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8186	2014-02-10 14:40:09 -08:00