3 commits

Author	SHA1	Message	Date
Bob Trahan	c970f7e89c	refactor pass 2 of N on DifferentialChangesetParser and bonus bug fix ... Summary: pull out some more stuff from the TwoUp renderer that's generically useful. also clean up $xhp variable and add a get method for the $coverage. Finally, fix T2177 while I'm in here. Test Plan: played around with Differential. Also opened things up in Firefox to verify T2177. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2009, T2177 Differential Revision: https://secure.phabricator.com/D4161	2012-12-11 17:16:11 -08:00
Bob Trahan	638449b483	removed some debugging code from D4117 ... Summary: whoops! Test Plan: no more debugging code Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D4121	2012-12-07 18:08:27 -08:00
Bob Trahan	75e8ff26f5	Refactor DifferentialChangesetParser -- pass 1 of N ... Summary: basically did my darnedest to pull out a TwoUp rendering view. Made a base class for the rendering views with "old" and "new" terminology rather than "left" and "right. Future revisions will finish cleaning up the terminology within the DifferentialChangesetParser itself and more of the ideas within T2009. Test Plan: been playing with differential all day Reviewers: epriestley Reviewed By: epriestley CC: vrana, chad, aran, Korvin Maniphest Tasks: T2009 Differential Revision: https://secure.phabricator.com/D4117	2012-12-07 16:19:57 -08:00