epriestley
fa38b70ba6
Fix message IDs and Herald URIs.
2011-04-10 08:46:39 -07:00
epriestley
17ea3cfab5
Link to commits when sending Differential Commit notifications.
...
Wholly untested. Unlikely to work.
2011-04-10 08:31:18 -07:00
epriestley
2c1ed9fd17
Render the cache correctly in DifferentialRevisionCommentView.
2011-04-09 22:34:41 -07:00
epriestley
dd1d593786
Don't send the action cue, use production URIs.
2011-04-09 22:33:31 -07:00
jungejason
cca849c762
Fix 'Transcript' links in Differential
...
Summary:
add filtering for MetaMTA transcripts, add Herald
transcripts, also fixed PhabricatorObjectHandleData to support commits.
Note that paging in the transcripts pages will be in a different diff.
Test Plan:
test the transcripts for both MetaMTA and Herald.
Reviewed By: epriestley
Reviewers: epriestley, tuomaspelkonen
CC: jungejason, epriestley
Differential Revision: 114
2011-04-08 01:10:05 -07:00
epriestley
22297b71a0
Close the loop on Diffusion commits posting back to Differential.
2011-04-07 21:59:42 -07:00
epriestley
68687a059a
Reintegrate Herald with Differential.
2011-04-07 20:59:51 -07:00
epriestley
361ec78b03
Add missing includes from XHPAST parse bug.
2011-04-06 23:14:58 -07:00
epriestley
11ea93260a
Sync up UUIDs and create project configs.
2011-04-05 21:55:04 -07:00
epriestley
8f5d01d451
Get rid of +x on a bunch of nonexecutable files because I failed to set
...
"create mask" on SMB. :/
2011-04-02 16:47:20 -07:00
tuomaspelkonen
28fe9f4eca
User preferences ported from tools
...
Summary:
Internal tools, e.g., differential and diffusion have user defined
preferences for monospaced font and the option for showing either the
name of the tool or the glyph of the tool in the title.
These preferences were ported to phabricator. These preferences can be
modified in /preferences/ and they both affect diffusion and differential
at the moment.
Test Plan:
* Created an empty database
* Loaded /preferences/ and modified the monospaced font and clicked save
* Confirmed that the same page was loaded with the message that preferences
have been saved and that the example text used the user defined font
* in /preferences/ changed the option to show tool names as plain text and
clicked save
* Confirmed that the same page was loaded with '[Preferences]' in the title
instead of a glyph
* These same tests were also executed for differential and diffusion
Reviewers: epriestley
CC: jungejason
Differential Revision: 91
2011-03-31 13:44:20 -07:00
epriestley
60918c9a9e
Improved change view support.
2011-03-30 19:22:11 -07:00
epriestley
3d5f03607b
Rough cut of Diffusion change view.
2011-03-30 17:36:32 -07:00
epriestley
f249ffc882
Fix Remarkup styling in Maniphest and Differential
...
Summary:
This makes some of the line spacing, paragraph spacing and layout
less terrible. In particular, fixes code blocks inside Differential inline
comments.
Test Plan:
Looked at Maniphest Tasks, Differential Revisions and Differential
inline comments with various flavors of remarkup in them.
Reviewed By: jungejason
Reviewers: tuomaspelkonen, jungejason
CC: jungejason
Differential Revision: 89
2011-03-29 22:02:02 -07:00
tuomaspelkonen
31dda42903
Changed 'Comment' to 'Clowncopterize' in Differential
...
Summary:
Back to the authentic roots.
Test Plan:
Verified that the button had the correct text in the UI.
Reviewed By: epriestley
Reviewers: epriestley
CC: epriestley
Differential Revision: 86
2011-03-29 16:09:21 -07:00
epriestley
370ba966db
Rough cut of herald transcripts and Differential adapter.
2011-03-24 21:32:26 -07:00
Slawek Biel
4c9850278c
[Differential: removing reviewed/reviewers check from the parser]
...
Summary:
As we've discussed the check is not needed.
Test Plan:
- php -l
Reviewed By: epriestley
Reviewers: jungejason, epriestley
CC: epriestley
Revert Plan:
sure
Other Notes:
Differential Revision: 81
2011-03-22 12:34:29 -07:00
epriestley
ad7a389106
Fix a bug where too many changesets make it to display.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-03-07 22:02:46 -08:00
epriestley
e98d1ae9be
Enhance Phabricator capabilities for differential.getcommitmessage (2)
...
Summary: Enables --edit workflow to behave properly [edit]
Test Plan: meta [what]
Reviewers:
CC: epriestley
Differential Revision: 26
2011-03-04 17:14:48 -08:00
jungejason
9bc04fe03d
Change hard-coded PHID types to constants.
...
Summary:
add a constants module
src/applications/phid/constants/PhabricatorPHIDConstants.
Test Plan:
Execute applications which were using the hard-coded string.
Differential Revision: 44
Reviewed By: epriestley
Reviewers: epriestley
CC: epriestley
2011-03-03 12:00:53 -08:00
epriestley
eccc76dae6
Fix some issues caught by HipHop, and work around some issues
...
caused by HipHop.
2011-02-26 21:01:42 -08:00
epriestley
3d796f0b59
Default to 'active'.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-22 23:39:09 -08:00
epriestley
27dc5eabd7
Make differential revision list less ambiguous.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-22 23:37:43 -08:00
epriestley
c6c6a2cc4c
Unify headsup action lists.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-20 13:02:40 -08:00
epriestley
8fe3c80b6c
Make header alignment/layout less horrible.
...
Summary: <table />s repruhsent
Test Plan:
Reviewers:
CC:
2011-02-20 10:00:29 -08:00
epriestley
c5c31d7eb9
Make auto-ccs work, delete some dead code, make inlines show up in email,
...
and resolve a display caching issue.
Summary:
Test Plan:
Reviewers:
CC:
2011-02-19 15:06:22 -08:00
epriestley
a04a88a843
Make subscribe/unsubscribe work properly on Revisions.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-19 14:36:13 -08:00
epriestley
eec3e8e3aa
Move object-selector closable to being usable.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-18 15:12:15 -08:00
epriestley
147d2e2e3d
Rought cut of search.
...
Summary: Botched this pretty badly in git so we'll see how much I broke. :/
Test Plan:
Reviewers:
CC:
2011-02-14 15:34:20 -08:00
epriestley
fcc467fe5e
Fix some derp with Differential revision formatting.
...
Summary:
- Prevent long comments from expanding the inline box.
- Make anchor links to inlines work properly.
- Get rid of "pre" white-space formatting in inline comments.
Test Plan: Viewed a revision with crazy comments in it.
Reviewers:
CC:
2011-02-13 16:00:21 -08:00
epriestley
8784b5bd3b
Link "DNNNN" and "TNNNN" in Phabricator remarkup.
...
Summary: Autolink Differential and Maniphest objects.
Test Plan: Typed "D12345 " and "T12345 " into the Differential comment preview,
got links. Typed "http://www.elsewhere.com/D12345 " and got a single link to
that URI, not a mess where the D12345 part linked incorrectly.
Reviewers: aran
CC:
Differential Revision: 35
2011-02-11 18:07:45 -08:00
epriestley
70fd45b139
Use the correct actor handle when sending DifferentialNewDiffMail.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 22:46:18 -08:00
epriestley
56880cc92e
Discard no-op transactions from transaction groups.
...
Move assignees to CC as a side effect of reassignment.
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 12:57:38 -08:00
epriestley
9eccb3e23d
Don't try to render RevisionRefs since they haven't been brought over yet.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 12:47:41 -08:00
epriestley
616c22eae2
I think this improves email a good deal, although it's hard to really test it
...
since Exchange has been down for like 30 minutes now. Push & Pray!
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 11:11:24 -08:00
epriestley
e3a91902b7
This might make emails work better.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 09:58:48 -08:00
epriestley
1369bd3dd4
Conduit: differential.getcommitmessage
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 09:41:26 -08:00
epriestley
bb8bc4ff54
Make commit message parsing at least sort of work.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 09:17:21 -08:00
epriestley
7c209590c1
Use "(?P<" for named capturing subpatterns.
...
Summary:
Test Plan:
Reviewers:
CC:
2011-02-09 09:13:07 -08:00
epriestley
5817840894
differential.createrevision
...
Summary: Conduit method.
Test Plan: Meta
Reviewers:
CC:
Differential Revision: 23
2011-02-06 13:56:11 -08:00
epriestley
787eb778b1
differential.parsecommitmessage
...
Test plan: meta
2011-02-06 13:46:39 -08:00
epriestley
1c586db9be
Revision comment drafts.
2011-02-05 16:57:21 -08:00
epriestley
50bfcd0a30
100-changeset cutoff.
2011-02-05 16:43:28 -08:00
epriestley
f0934e655f
Fix some typos, restore outline styles.
2011-02-05 12:33:53 -08:00
epriestley
de2a9c634c
Differential lazyweb diff create workflow.
2011-02-05 12:20:18 -08:00
epriestley
53f2a433f7
Collapse comments in long threads.
2011-02-05 11:06:56 -08:00
epriestley
18c0515440
Add reviewers workflow fixes.
2011-02-04 22:45:42 -08:00
epriestley
38e53df53c
Make revision CCs work properly.
2011-02-04 18:16:02 -08:00
epriestley
905870d793
Various fixes, particularly on the revision update workflow.
2011-02-04 17:53:14 -08:00
epriestley
8b7755b834
Changeset anchor links.
2011-02-04 16:18:08 -08:00
epriestley
12df78ed6a
Rough cut of diff-of-diffs.
2011-02-03 15:41:58 -08:00
epriestley
5fd28d35d9
Diff-of-diffs radio button logic.
2011-02-03 13:26:52 -08:00
epriestley
c93dd9c090
Flesh out some DarkConsole stuff.
2011-02-02 22:38:42 -08:00
epriestley
5eb9bce6d4
Remove some commented-out versions of some stuff that works now.
2011-02-02 19:44:12 -08:00
epriestley
4aa72aa5ff
Inline comment-related fixes.
2011-02-02 19:38:43 -08:00
epriestley
223ac18287
Straighten out some reviewer-realtd horribleness.
2011-02-02 17:38:03 -08:00
epriestley
ba26f67687
Add some comment caching stuff.
2011-02-02 16:36:53 -08:00
epriestley
c5ce156e71
Edit/Delete for inline comments
2011-02-02 13:51:45 -08:00
epriestley
759eec3a77
Very rough cut of DarkConsole + XHProf
2011-02-02 13:48:52 -08:00
epriestley
246cba2bf0
InlineComments
2011-02-01 21:09:28 -08:00
epriestley
9dac0ed9f1
Bring in JX.Workflow and the inline commenting behavior, plus sync Javelin.
2011-02-01 15:52:04 -08:00
epriestley
233953bc4a
Straighten out the "show more context" stuff.
2011-01-31 20:38:13 -08:00
epriestley
6a94f054d2
Fix array/string type bug in comment saving.
2011-01-31 20:03:43 -08:00
epriestley
4736b320ff
Differential comment previews.
2011-01-31 18:05:20 -08:00
epriestley
400524abf8
Get rid of some local.aphront references.
2011-01-31 16:59:01 -08:00
epriestley
e28c2e8899
Profile image stuff
2011-01-31 16:00:42 -08:00
epriestley
03fec6e911
PhabricatorEnv
...
'infratructure' -> 'infrastructure' (rofl)
Recaptcha
Email Login / Forgot Password
Password Reset
2011-01-31 11:55:26 -08:00
epriestley
29f7219a49
CSRF / Logout
2011-01-30 18:52:29 -08:00
epriestley
58d1506499
Clean up the revision list view a bit.
2011-01-30 18:24:57 -08:00
epriestley
a34f946b8e
Remarkup for Differential comments.
2011-01-30 13:20:56 -08:00
epriestley
9c3d00de03
Write pathway for Differential Comments
2011-01-30 12:08:58 -08:00
epriestley
5f32fb3283
AddCommentView
2011-01-30 11:02:22 -08:00
epriestley
c55b1ed9bb
Basic Differential revision feedback view.
2011-01-30 10:37:58 -08:00
epriestley
7b9c4c5f61
DifferentialRevisionView
2011-01-29 15:37:41 -08:00
epriestley
9f1659b4c4
DifferentialRevisionList
2011-01-27 13:12:07 -08:00
epriestley
63c842105c
Differential Revision relationships
2011-01-27 10:07:59 -08:00
epriestley
de1fb8ac7d
DifferentialRevisionEditor
2011-01-26 17:17:49 -08:00
epriestley
ccf7df6093
Authentication
2011-01-26 15:34:20 -08:00
epriestley
2b7b03ad0c
ChangesetParseCache
2011-01-25 16:10:48 -08:00
epriestley
a997e77693
RevisionList
2011-01-25 16:02:36 -08:00
epriestley
14ed5482ab
Typeaheads
2011-01-25 14:41:32 -08:00
epriestley
14163aaeef
RevisionEdit
2011-01-25 13:40:57 -08:00
epriestley
16ad2386d8
Javelin integration.
2011-01-25 12:41:55 -08:00
epriestley
7bb0db1365
Celerity, a Haste-style static resource management system.
2011-01-25 10:18:44 -08:00
epriestley
52126c5479
Add proper syntax highlighting with Phutil.
2011-01-24 17:39:14 -08:00
epriestley
a3df19976f
DifferentialChangesetView
2011-01-24 17:24:40 -08:00
epriestley
e85ecd03de
DifferentialDiffView
2011-01-24 14:44:58 -08:00
epriestley
7779c67668
Conduit: differential.setdiffproperty
2011-01-24 12:14:32 -08:00
epriestley
2bea542920
Conduit: user.find
2011-01-24 12:05:49 -08:00
epriestley
dec8bac3a3
Conduit: differential.creatediff
2011-01-24 11:28:12 -08:00
epriestley
fb9b0db726
Move 'review' -> 'differential'.
2011-01-23 18:10:20 -08:00