8 commits

Author	SHA1	Message	Date
epriestley	a64d127e25	Add "is merge commit" Herald field for pre-commit rules ... Summary: Ref T4195. This allows you to write rules which disallow merge commits. Also make the reject message a little more useful. Test Plan: remote: This push was rejected by Herald push rule H27. remote: Change: commit/daed0d448404 remote: Rule: No Merges remote: Reason: No merge commits allowed. If you must push a merge, include "@force-merge" in the commit message. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7809	2013-12-20 12:39:40 -08:00
epriestley	72c73d644b	Add an "Accepted Differential revision" field to Commit and pre-commit Content Herald rules ... Summary: Refs T4195. Fixes T3936. You can't currently write rules like "block commits unless they're attached to an **accepted** revision"; allow that. Test Plan: Pushed commits into a rule with this field, saw it work / not crash. Reviewers: btrahan Reviewed By: btrahan CC: aran, mbishopim3 Maniphest Tasks: T3936, T4195 Differential Revision: https://secure.phabricator.com/D7807	2013-12-20 12:39:13 -08:00
epriestley	2436458b90	Implement "Differential Revision" fields in Herald pre-commit content adapter ... Summary: Ref T4195. Allows you to write revision-based commit hooks, e.g. block all commits with no corresponding revision. Test Plan: Here's are the fields populating: {F90989} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7806	2013-12-20 12:39:01 -08:00
epriestley	134c8f5547	Add "Author" and "Committer" fields to Herald pre-commit content hooks ... Summary: Ref T4195. Adds "Author" and "Committer" fields. Test Plan: Created a rule using these fields: {F90897} ...then pushed git, mercurial and svn commits and verified the correct values populated in the transcript: {F90898} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7802	2013-12-19 11:05:31 -08:00
epriestley	151f01ae94	Implement "Body" field in Herald pre-commit content hooks ... Summary: Ref T4195. Adds support for writing rules against commit message bodies. Test Plan: Pushed git, hg, svn commits and verified their bodies populated correctly in transcripts. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7796	2013-12-19 06:56:01 -08:00
epriestley	5f4df0f3e3	Support "changed filename" and "file content" fields for commit content Herald rules ... Summary: Ref T4195. Adds support for diff content rules. Test Plan: Pushed SVN and Git changes through, saw them generate reasonable transcripts. Mercurial still isn't hooked up to this phase. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7791	2013-12-18 14:18:58 -08:00
epriestley	e115f11f80	Provide basic commit content hooks for Herald ... Summary: Ref T4195. This doesn't provide any interesting fields yet (content, affected paths, commit message) but fires the hook correctly. Test Plan: Added a blocking hook and saw it fire. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7789	2013-12-18 14:18:45 -08:00
epriestley	3386920971	Add Herald support for blocking ref changes ... Summary: Ref T4195. Allows users to write Herald rules which block ref changes. For example, you can write a rule like `alincoln can not create branches`, or `no one can push to the branch "frozen"`. Test Plan: This covers a lot of ground. I created and pushed a bunch of rules, then looked at transcripts, in general. Here are some bits in detail: Here's a hook-based reject message: >>> orbital ~/repos/POEMS $ git push Counting objects: 5, done. Delta compression using up to 8 threads. Compressing objects: 100% (3/3), done. Writing objects: 100% (3/3), 274 bytes, done. Total 3 (delta 2), reused 0 (delta 0) remote: +---------------------------------------------------------------+ remote: | * * * PUSH REJECTED BY EVIL DRAGON BUREAUCRATS * * * | remote: +---------------------------------------------------------------+ remote: \ remote: \ ^ /^ remote: \ / \ // \ remote: \ |\___/| / \// .\ remote: \ /V V \__ / // | \ \ *----* remote: / / \/_/ // | \ \ \ | remote: @___@` \/_ // | \ \ \/\ \ remote: 0/0/| \/_ // | \ \ \ \ remote: 0/0/0/0/| \/// | \ \ | | remote: 0/0/0/0/0/_|_ / ( // | \ _\ | / remote: 0/0/0/0/0/0/`/,_ _ _/ ) ; -. | _ _\.-~ / / remote: ,-} _ *-.|.-~-. .~ ~ remote: \ \__/ `/\ / ~-. _ .-~ / remote: \____(Oo) *. } { / remote: ( (--) .----~-.\ \-` .~ remote: //__\\ \ DENIED! ///.----..< \ _ -~ remote: // \\ ///-._ _ _ _ _ _ _{^ - - - - ~ remote: remote: remote: This commit was rejected by Herald pre-commit rule H24. remote: Rule: No Branches Called Blarp remote: Reason: "blarp" is a bad branch name remote: To ssh://dweller@localhost/diffusion/POEMS/ ! [remote rejected] blarp -> blarp (pre-receive hook declined) error: failed to push some refs to 'ssh://dweller@localhost/diffusion/POEMS/' Here's a transcript, showing that all the field values populate sensibly: {F90453} Here's a rule: {F90454} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4195 Differential Revision: https://secure.phabricator.com/D7782	2013-12-17 15:23:55 -08:00