4 commits

Author	SHA1	Message	Date
Joshua Spence	495cb7a2e0	Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract ... Summary: Fixes T9625. As explained in a `TODO` comment, seems reasonable enough. Test Plan: Unit tests. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: Korvin, hach-que Maniphest Tasks: T9625 Differential Revision: https://secure.phabricator.com/D14068	2015-11-03 06:47:12 +11:00
Joshua Spence	97a8700e45	Rename PHIDType classes ... Summary: Ref T5655. Rename `PhabricatorPHIDType` subclasses for clarity (see discussion in D9839). I'm not too keen on some of the resulting class names, so feel free to suggest alternatives. Test Plan: Ran unit tests. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin, hach-que Maniphest Tasks: T5655 Differential Revision: https://secure.phabricator.com/D9986	2014-07-24 08:05:46 +10:00
Joshua Spence	254542237a	Simplify the implementation of PhabricatorPHIDType subclasses ... Summary: Instead of implementing the `getTypeConstant` method in all subclasses of `PhabricatorPHIDType`, provide a `final` implementation in the base class which uses reflection. See D9837 for a similar implementation. Test Plan: Ran `arc unit`. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D9985	2014-07-22 00:38:23 +10:00
epriestley	8909f8ec59	Modernize OAuthServer PHIDs and Queries ... Summary: - Modernize PHID types. - Implement `PhabricatorPolicyInterface`. - Make queries policy aware. Test Plan: Browsed client and authorization lists. Reviewers: btrahan Reviewed By: btrahan Subscribers: chad, epriestley Differential Revision: https://secure.phabricator.com/D8560	2014-03-18 13:27:55 -07:00