3 commits

Author	SHA1	Message	Date
epriestley	5863f792a6	Remove many redundant implementations of canLoadNamedObject() ... Summary: These just got copy/pasted like crazy, the base class has the correct default implementation. (I'm adding "H" for Herald Rules, which is why I was in this code.) I also documented the existing prefixes at [[ Object Name Prefixes ]]. Test Plan: Verified base implementation. Typed some object names into the jump nav. Reviewers: btrahan Reviewed By: btrahan CC: hach-que, aran Differential Revision: https://secure.phabricator.com/D7785	2013-12-18 12:00:01 -08:00
epriestley	2a5c987c71	Lock policy queries to their applications ... Summary: While we mostly have reasonable effective object accessibility when you lock a user out of an application, it's primarily enforced at the controller level. Users can still, e.g., load the handles of objects they can't actually see. Instead, lock the queries to the applications so that you can, e.g., never load a revision if you don't have access to Differential. This has several parts: - For PolicyAware queries, provide an application class name method. - If the query specifies a class name and the user doesn't have permission to use it, fail the entire query unconditionally. - For handles, simplify query construction and count all the PHIDs as "restricted" so we get a UI full of "restricted" instead of "unknown" handles. Test Plan: - Added a unit test to verify I got all the class names right. - Browsed around, logged in/out as a normal user with public policies on and off. - Browsed around, logged in/out as a restricted user with public policies on and off. With restrictions, saw all traces of restricted apps removed or restricted. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7367	2013-10-21 17:20:27 -07:00
epriestley	5899ae08b3	Add storage for custom policies ... Summary: Ref T603. Allows custom policies to be saved. No integration with policy controls yet. Test Plan: mysql> select * from policy where id = 3\G *************************** 1. row *************************** id: 3 phid: PHID-PLCY-e4v2fnbyuibi4supl5tn rules: [{"action":"allow","rule":"PhabricatorPolicyRuleAdministrators","value":null},{"action":"allow","rule":"PhabricatorPolicyRuleProjects","value":["PHID-PROJ-cwovm5gn2ilubjehcdgd"]},{"action":"allow","rule":"PhabricatorPolicyRuleLunarPhase","value":"new"}] defaultAction: deny dateCreated: 1381437466 dateModified: 1381437466 1 row in set (0.00 sec) Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7282	2013-10-10 16:09:51 -07:00