revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
Code Issues Releases Wiki Activity
4599 commits 3 branches 7 tags 153 MiB
Commit graph

4256 commits

Author SHA1 Message Date
epriestley
fd1318bf4c Enable task editing in Maniphest. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-20 14:15:53 -08:00
epriestley
c6c6a2cc4c Unify headsup action lists. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-20 13:02:40 -08:00
epriestley
d919ddb808 Safari tricked me. ;_; 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-20 10:16:16 -08:00
epriestley
c92abacfda Update the celerity map. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-20 10:03:35 -08:00
epriestley
8fe3c80b6c Make header alignment/layout less horrible. 
Summary: <table />s repruhsent

Test Plan:

Reviewers:

CC:
 2011-02-20 10:00:29 -08:00
epriestley
c457032645 Slightly more sophisticated profiles. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 18:28:41 -08:00
epriestley
f0066ed742 Very very rough cut of profiles. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 17:33:53 -08:00
epriestley
490280e6eb Add email to settings. Disable arbitrary user editing. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 16:46:14 -08:00
epriestley
2aece70eaf Proper indexing for Differential revisions. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 16:29:06 -08:00
epriestley
c5c31d7eb9 Make auto-ccs work, delete some dead code, make inlines show up in email, 
and resolve a display caching issue.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 15:06:22 -08:00
epriestley
a04a88a843 Make subscribe/unsubscribe work properly on Revisions. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 14:36:13 -08:00
epriestley
0b20c7a5ed Emit shielded JSON from Conduit endpoints. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-19 13:02:25 -08:00
epriestley
9216f193e1 conduit.ping 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 22:36:32 -08:00
epriestley
c5b3352865 differential.getcommitpaths 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 22:36:23 -08:00
epriestley
e691dca6c6 Provide differential.getdiff, useful for 'arc patch'. 
Summary:

Test Plan: ran 'arc patch'

Reviewers:

CC:
 2011-02-18 22:15:28 -08:00
epriestley
0e7729c78f Make priority the default sort and order. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 21:57:34 -08:00
epriestley
cf22d8c6cb Fix connection retry code to actually retry connections, instead of reading the 
dead connection out of the connection cache.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 21:48:20 -08:00
epriestley
21650c47b6 Make owner search queries work. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 17:36:25 -08:00
epriestley
505c82236d Improve search functionality. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 17:16:00 -08:00
epriestley
eec3e8e3aa Move object-selector closable to being usable. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-18 15:12:15 -08:00
epriestley
258e0cdded Very basic Object Selector interface. 
Summary: Interface for selecting objects to attach to other objects
(e.g., Maniphest tasks to Differential diffs and vice versa).

Test Plan: still rough

Reviewers:

CC:
 2011-02-16 23:00:13 -08:00
epriestley
0b1450c5f9 Add framebusting to Phabricator. 
Summary:
Technically we didn't have it in the first place, but should. Also
add in X-Frame-Options for double-plus-good.

Test Plan:
Created a page with Phabricator in an <iframe />, got busted out
of it. Added in the X-Frame-Options, got an empty iframe.

Differential Revision: 38
Reviewed By: tomo
Reviewers: mroch, tomo
 2011-02-16 22:58:44 -08:00
epriestley
147d2e2e3d Rought cut of search. 
Summary: Botched this pretty badly in git so we'll see how much I broke. :/

Test Plan:

Reviewers:

CC:
 2011-02-14 15:34:20 -08:00
epriestley
fcc467fe5e Fix some derp with Differential revision formatting. 
Summary:
  - Prevent long comments from expanding the inline box.
  - Make anchor links to inlines work properly.
  - Get rid of "pre" white-space formatting in inline comments.

Test Plan: Viewed a revision with crazy comments in it.

Reviewers:

CC:
 2011-02-13 16:00:21 -08:00
epriestley
580116b1c1 Herp derp. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-12 18:49:28 -08:00
epriestley
f55a30a288 Rough cut of Repositories and GitHub post-receive hooks. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-12 18:26:15 -08:00
epriestley
8784b5bd3b Link "DNNNN" and "TNNNN" in Phabricator remarkup. 
Summary: Autolink Differential and Maniphest objects.

Test Plan: Typed "D12345" and "T12345" into the Differential comment preview,
got links. Typed "http://www.elsewhere.com/D12345" and got a single link to
that URI, not a mess where the D12345 part linked incorrectly.

Reviewers: aran

CC:

Differential Revision: 35
 2011-02-11 18:07:45 -08:00
epriestley
1bb055d163 Introduction doc. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 17:53:35 -08:00
epriestley
3b7d73c41b Add a "Config" plugin to DarkConsole. 
Summary: This plugin lets you see how the host is configured at runtime.

Test Plan:

Reviewers:

CC:
 2011-02-11 16:48:43 -08:00
epriestley
bacf622178 Use Filesystem::readRandomBytes() instead of copy/pasting reads of /dev/urandom 
everywhere.

Summary:

Test Plan: Logged out and in a few times, verified I got reasonable session
keys assigned.

Reviewers:

CC:
 2011-02-11 16:12:34 -08:00
epriestley
2082d5e227 Minor doc tweaks. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 16:12:02 -08:00
epriestley
2e4022aca8 Improve docs to a semi-defensible level. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 14:58:45 -08:00
epriestley
cb6aa26ee3 Lint junk. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 13:17:19 -08:00
epriestley
5fbeac4abc Border-oriented priority junk. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 13:07:02 -08:00
epriestley
8c7581b148 Make task summary views slightly prettier. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 11:21:18 -08:00
epriestley
0d1da3df15 Improve filtering and sorting options for Maniphest. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-11 10:29:30 -08:00
epriestley
33a9019a89 Improve availability of MetaMTA debugging info. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-10 16:19:17 -08:00
epriestley
175884e5d2 Merge branch 'differential.find' 2011-02-10 16:15:31 -08:00
epriestley
a3584efe78 Merge branch 'upload' 2011-02-10 16:15:18 -08:00
epriestley
03b88d1da3 Don't throw when a user saves account settings without changing their profile 
picture.

Summary:
Going to Settings -> Account and hitting "Save" without selecting
a file in the file dialog currently throws.

Test Plan:
Went to Settings -> Account and hit "Save" without making changes.
No exception. Then uploaded a picture normally.

Differential Revision: 30
Reviewed By: tomo
Reviewers: tomo
 2011-02-10 16:15:11 -08:00
epriestley
70fd45b139 Use the correct actor handle when sending DifferentialNewDiffMail. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 22:46:18 -08:00
epriestley
99a40ab666 Fix differential.find and the web API for the conduit console 
Summary: differential.find was fataling in the console because of a bad
constant, and you couldn't submit requests requiring authentication because
the auth stuff didn't know to look for web sessions. Resolve these issues.

Test Plan: Hit differential.find successfully, ran a user.find query from
the web console without issues.

Reviewers: tomo

CC:

Differential Revision: 31
 2011-02-09 22:43:24 -08:00
epriestley
e8e185ceb3 Make Maniphest emails align title numbers better and fix a transaction 
aggregation bug.

Summary:
Transactions always aggregated even when separated by large time
differences becuase of some clown typoing; fix that. Also make the subject
lines for tasks align better in the inbox.

Test Plan:
I'm feeling lucky.

Differential Revision: 29
Reviewed By: tomo
Reviewers: tomo
 2011-02-09 20:45:28 -08:00
epriestley
193dbf16b4 Very basic daemon infrastructure, plus MetaMTA daemon. 
Summary: Amazon SES seems to be working well, except that it takes more than a
second to send mail in-process. Kick it out of process. (Between this and the
ImplementationAdapter layer, MetaMTA almost makes sense. :/)

Test Plan: Ran the daemon and got a flood of unsent test email.

Reviewers:

CC:
 2011-02-09 17:39:55 -08:00
epriestley
b7801c44fe Don't double-generate message IDs. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 16:46:33 -08:00
epriestley
91fb157253 Use the task title as the page title for Maniphest task detail views. 
Summary: Instead of "Create Task", show the task's ID and name in the page
title.

Test Plan: Looked at a task. Also double-cheked XSS junk and plugged a hole.

Reviewers: cpiro

CC:

Differential Revision: 27
 2011-02-09 16:38:51 -08:00
epriestley
5d586f149d Improve task list filtering views. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 16:29:46 -08:00
epriestley
38c6ce273a Don't duplicate comments in add-CC side effects. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 16:20:08 -08:00
epriestley
2527dcddce Add a bunch of threading headers to Maniphest. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 16:13:04 -08:00
epriestley
8347729fc0 When sending with Amazon SES, use the AWS sendRawEmail API instead of sendEmail, 
so we can send custom headers.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 16:05:06 -08:00
epriestley
076f342aed Fix an issue with comment group aggregation. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 14:28:16 -08:00
epriestley
1636e8274a Maniphest style tweaks. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 14:10:12 -08:00
epriestley
56880cc92e Discard no-op transactions from transaction groups. 
Move assignees to CC as a side effect of reassignment.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 12:57:38 -08:00
epriestley
9eccb3e23d Don't try to render RevisionRefs since they haven't been brought over yet. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 12:47:41 -08:00
epriestley
539b245055 Group Maniphest transactions. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 12:47:24 -08:00
epriestley
b500105a56 Maniphest styling pass 
Summary: Makes maniphest slightly less gross looking

Test Plan: Looked at it

Reviewers: tomo

CC:

Differential Revision: 26
 2011-02-09 11:39:20 -08:00
epriestley
616c22eae2 I think this improves email a good deal, although it's hard to really test it 
since Exchange has been down for like 30 minutes now. Push & Pray!

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 11:11:24 -08:00
epriestley
e3a91902b7 This might make emails work better. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 09:58:48 -08:00
epriestley
7aa95fd112 differential.markcommitted 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 09:48:26 -08:00
epriestley
1369bd3dd4 Conduit: differential.getcommitmessage 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 09:41:26 -08:00
epriestley
bb8bc4ff54 Make commit message parsing at least sort of work. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 09:17:21 -08:00
epriestley
7c209590c1 Use "(?P<" for named capturing subpatterns. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-09 09:13:07 -08:00
epriestley
21058f9a08 Fix an issue with "Assigned To" display in Maniphest 
Summary: I inverted the logic.

Test Plan: Will push

Reviewers: tomo, aran

CC:

Differential Revision: 25
 2011-02-08 21:09:56 -08:00
epriestley
6ec5e682f4 Maniphest wireframes 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-08 20:39:56 -08:00
epriestley
3018d44279 When a user enables DarkConsole, make it visible. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-08 10:36:21 -08:00
epriestley
8098954776 Add basic Amazon SES support. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-07 21:08:32 -08:00
epriestley
058cb69308 Use the long-form "?P<...>" for named capturing subgroups since some versions of 
stuff choke on the short form.

Summary:

Test Plan:

Reviewers:

CC:
 2011-02-07 20:56:27 -08:00
epriestley
7aa6943890 Choose a more appropriate glyph for People. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-07 20:56:05 -08:00
epriestley
c69a1aa050 Make differential.find work okayish 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-07 11:46:01 -08:00
epriestley
31abf0dfb5 differential.find 
Summary:

Test Plan: meta

Reviewers:

CC:
 2011-02-06 14:43:26 -08:00
epriestley
f07e4f2c16 Make some email stuff work better. 
Summary:

Test Plan:

Reviewers:

CC:
 2011-02-06 14:22:09 -08:00
epriestley
df49a6c721 differential.updaterevision 
Summary:

Test Plan: meta

Reviewers:

CC:

Differential Revision: 24
 2011-02-06 14:01:42 -08:00
epriestley
5817840894 differential.createrevision 
Summary: Conduit method.

Test Plan: Meta

Reviewers:

CC:

Differential Revision: 23
 2011-02-06 13:56:11 -08:00
epriestley
787eb778b1 differential.parsecommitmessage 
Test plan: meta
 2011-02-06 13:46:39 -08:00
epriestley
99aee37866 Lint fluff. 2011-02-06 12:58:01 -08:00
epriestley
701d029123 Add some profile upload jonx. 2011-02-05 23:56:06 -08:00
epriestley
78f0b4aff9 Use ".arcrc" for the user settings to avoid confusion with project ".arcconfig". 2011-02-05 22:37:59 -08:00
epriestley
605268f9aa Some acutal conduit authentication. 2011-02-05 22:36:21 -08:00
epriestley
1c586db9be Revision comment drafts. 2011-02-05 16:57:21 -08:00
epriestley
50bfcd0a30 100-changeset cutoff. 2011-02-05 16:43:28 -08:00
epriestley
f0934e655f Fix some typos, restore outline styles. 2011-02-05 12:33:53 -08:00
epriestley
de2a9c634c Differential lazyweb diff create workflow. 2011-02-05 12:20:18 -08:00
epriestley
addfe3aa79 DarkConsole toggle, workflow behavior. 2011-02-05 11:45:13 -08:00
epriestley
53f2a433f7 Collapse comments in long threads. 2011-02-05 11:06:56 -08:00
epriestley
18c0515440 Add reviewers workflow fixes. 2011-02-04 22:45:42 -08:00
epriestley
a35ae4c2a0 Fix a reset() thingie. 2011-02-04 18:58:52 -08:00
epriestley
94dd5c6917 Slightly declown my stunning "design" skills. 2011-02-04 18:24:03 -08:00
epriestley
38e53df53c Make revision CCs work properly. 2011-02-04 18:16:02 -08:00
epriestley
905870d793 Various fixes, particularly on the revision update workflow. 2011-02-04 17:53:14 -08:00
epriestley
8b7755b834 Changeset anchor links. 2011-02-04 16:18:08 -08:00
epriestley
12df78ed6a Rough cut of diff-of-diffs. 2011-02-03 15:41:58 -08:00
epriestley
5fd28d35d9 Diff-of-diffs radio button logic. 2011-02-03 13:26:52 -08:00
epriestley
c93dd9c090 Flesh out some DarkConsole stuff. 2011-02-02 22:38:42 -08:00
epriestley
5eb9bce6d4 Remove some commented-out versions of some stuff that works now. 2011-02-02 19:44:12 -08:00
epriestley
4aa72aa5ff Inline comment-related fixes. 2011-02-02 19:38:43 -08:00
epriestley
223ac18287 Straighten out some reviewer-realtd horribleness. 2011-02-02 17:38:03 -08:00
epriestley
ba26f67687 Add some comment caching stuff. 2011-02-02 16:36:53 -08:00
epriestley
a5c0c277ca Very slightly less terrible XHProf implementation. 2011-02-02 16:14:23 -08:00
epriestley
9fbb0cc40a Full lint pass. 2011-02-02 13:59:52 -08:00
epriestley
c5ce156e71 Edit/Delete for inline comments 2011-02-02 13:51:45 -08:00
epriestley
759eec3a77 Very rough cut of DarkConsole + XHProf 2011-02-02 13:48:52 -08:00
epriestley
246cba2bf0 InlineComments 2011-02-01 21:09:28 -08:00
epriestley
9dac0ed9f1 Bring in JX.Workflow and the inline commenting behavior, plus sync Javelin. 2011-02-01 15:52:04 -08:00
epriestley
4faad5b3f1 Add a default-send behavior to MetaMTA. 2011-01-31 21:13:38 -08:00
epriestley
233953bc4a Straighten out the "show more context" stuff. 2011-01-31 20:38:13 -08:00
epriestley
6a94f054d2 Fix array/string type bug in comment saving. 2011-01-31 20:03:43 -08:00
epriestley
4736b320ff Differential comment previews. 2011-01-31 18:05:20 -08:00
epriestley
400524abf8 Get rid of some local.aphront references. 2011-01-31 16:59:01 -08:00
epriestley
1e561a2bbc Make MySQL stuff configurable 2011-01-31 16:50:08 -08:00
epriestley
e28c2e8899 Profile image stuff 2011-01-31 16:00:42 -08:00
epriestley
03fec6e911 PhabricatorEnv 
'infratructure' -> 'infrastructure' (rofl)
Recaptcha
Email Login / Forgot Password
Password Reset
 2011-01-31 11:55:26 -08:00
epriestley
25aae76c8a Basic Facebook OAuth implementation. 2011-01-30 21:28:45 -08:00
epriestley
29f7219a49 CSRF / Logout 2011-01-30 18:52:29 -08:00
epriestley
58d1506499 Clean up the revision list view a bit. 2011-01-30 18:24:57 -08:00
epriestley
a34f946b8e Remarkup for Differential comments. 2011-01-30 13:20:56 -08:00
epriestley
9c3d00de03 Write pathway for Differential Comments 2011-01-30 12:08:58 -08:00
epriestley
5f32fb3283 AddCommentView 2011-01-30 11:02:22 -08:00
epriestley
c55b1ed9bb Basic Differential revision feedback view. 2011-01-30 10:37:58 -08:00
epriestley
406a14ebe5 Make 404 page somewhat prettier. 2011-01-30 09:15:01 -08:00
epriestley
6c37f918b1 Somewhat proper 404 page, plus HTTP response code. 2011-01-30 08:44:28 -08:00
epriestley
9f04548ab9 I guess this can support JS too. 2011-01-30 08:33:40 -08:00
epriestley
0c8b04d5a8 Add packaging to Celerity. 2011-01-29 16:10:05 -08:00
epriestley
7b9c4c5f61 DifferentialRevisionView 2011-01-29 15:37:41 -08:00
epriestley
9f1659b4c4 DifferentialRevisionList 2011-01-27 13:12:07 -08:00
epriestley
63c842105c Differential Revision relationships 2011-01-27 10:07:59 -08:00
epriestley
de1fb8ac7d DifferentialRevisionEditor 2011-01-26 17:17:49 -08:00
epriestley
d37692ac06 Set 'From' correctly in MetaMTA. 2011-01-26 16:02:12 -08:00
epriestley
ccf7df6093 Authentication 2011-01-26 15:34:20 -08:00
epriestley
336a8b3212 Mailing lists 2011-01-26 11:30:23 -08:00
epriestley
2112673f06 PHPMailerLite 2011-01-26 09:57:33 -08:00
epriestley
a6274d9270 MetaMetaView 2011-01-26 09:20:09 -08:00
epriestley
7bd6169035 PhabricatorObjectHandles 2011-01-26 09:02:52 -08:00
epriestley
bc57b12ef0 MetaMTA 2011-01-26 08:00:52 -08:00
epriestley
2b7b03ad0c ChangesetParseCache 2011-01-25 16:10:48 -08:00
epriestley
a997e77693 RevisionList 2011-01-25 16:02:36 -08:00
epriestley
14ed5482ab Typeaheads 2011-01-25 14:41:32 -08:00
epriestley
14163aaeef RevisionEdit 2011-01-25 13:40:57 -08:00
epriestley
16ad2386d8 Javelin integration. 2011-01-25 12:41:55 -08:00
epriestley
e284d5b5dc Distribute Celerity includes. 2011-01-25 11:32:46 -08:00
epriestley
7bb0db1365 Celerity, a Haste-style static resource management system. 2011-01-25 10:18:44 -08:00
epriestley
fed4c583c5 Add Javelin. 2011-01-25 08:18:27 -08:00
epriestley
52126c5479 Add proper syntax highlighting with Phutil. 2011-01-24 17:39:14 -08:00
epriestley
a3df19976f DifferentialChangesetView 2011-01-24 17:24:40 -08:00
epriestley
e85ecd03de DifferentialDiffView 2011-01-24 14:44:58 -08:00
epriestley
7779c67668 Conduit: differential.setdiffproperty 2011-01-24 12:14:32 -08:00
epriestley
2bea542920 Conduit: user.find 2011-01-24 12:05:49 -08:00
epriestley
9f026d7892 Conduit: conduit.connect 2011-01-24 11:34:29 -08:00
epriestley
dec8bac3a3 Conduit: differential.creatediff 2011-01-24 11:28:12 -08:00
epriestley
2aaa95e640 Conduit server-side basics. 2011-01-24 10:52:35 -08:00
epriestley
fb9b0db726 Move 'review' -> 'differential'. 2011-01-23 18:10:20 -08:00
epriestley
89dae65c35 Basic user/account tool. 2011-01-23 18:09:16 -08:00
epriestley
0eac30d80d Phabricator file upload application. 2011-01-23 14:04:07 -08:00
epriestley
2c7e71cac5 Introduce PHID generation. 2011-01-22 22:07:59 -08:00
Evan Priestley
eecc003a62 More phabricator organizational stuff. 2011-01-22 18:00:19 -08:00
epriestley
85198b3d06 Distinguish between aphront and phabricator. 2011-01-22 17:45:28 -08:00
epriestley
76258ce0e1 Import some code, some of which may be relevant to the project. 2011-01-17 19:31:39 -08:00