3 commits

Author	SHA1	Message	Date
epriestley	f852a09e1c	Whitelist blacklisting pcntl_ functions for setup checks so Debian installs don't fatal instantly ... Summary: See IRC. This is dumb but I think we should try to work by default on Debian, and it doesn't cost us too much. See inline comment for more. Test Plan: - No `disable_functions`, restarted, worked fine. - Set `disable_functions = pcntl_derp`, restarted, worked fine. - Set `disable_functions = derp`, restarted, setup fatal. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D6741	2013-08-13 12:23:29 -07:00
epriestley	b7387f314b	Raise a setup fatal for 'disable_functions' or 'disable_classes' ... Summary: Fixes T3709. PHP has two configuration options ('disable_functions', 'disable_classes') which allow functions and classes to be blacklisted at runtime. Since these break things in an unclear way, raise a setup fatal if they are set. We take a slightly more tailored approach to these in `phd` already, but I'd rather try just saying "no, this is bad" and see if we can get away with it. I suspect we can, and there's no legitimate reason to blacklist functions given that Phabricator must have access to, e.g., `proc_open()`. Test Plan: {F54058} Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3709 Differential Revision: https://secure.phabricator.com/D6739	2013-08-13 10:11:05 -07:00
epriestley	27ec272057	Move open_basedir and safe_mode checks into new setup ... Summary: Newer and shinier! Test Plan: Intentionally misconfigured myself into all three setup failures (safe_mode, open_basedir/fatal, open_basedir/nonfatal). Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2228 Differential Revision: https://secure.phabricator.com/D4589	2013-01-22 16:15:54 -08:00