4 commits

Author	SHA1	Message	Date
epriestley	b2890eeb0e	Add "final" to all Phabricator "Controller" classes ... Summary: These are all unambiguously unextensible. Issues I hit: - Maniphest Change/Diff controllers, just consolidated them. - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects. - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962. Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1843	2012-03-09 15:46:25 -08:00
vrana	fe4d717cc7	Escape result of PhabricatorOAuthProvider::getProviderName() ... Test Plan: /settings/page/facebook/ Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1556	2012-02-02 18:35:45 -08:00
epriestley	d3efdcff03	Modularize oauth.	2011-02-27 20:38:11 -08:00
epriestley	b462349ec8	OAuth linking/unlinking controls. ... Summary: Test Plan: Reviewers: CC:	2011-02-21 23:25:14 -08:00