1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 16:16:14 +01:00
Commit graph

2 commits

Author SHA1 Message Date
Valerio Bozzolan
827f63a065 Cleanup unused cowsay files (related to legacy Perl binary version)
Summary:
Premising that Remarkup supports a fully-featured cowsay generator (!)... since 2015 this awesome
thing no longer requires a binary cowsay command, since everything was rewritten in the core:

c705c8011e

So, some files from the legacy cowsay version in Perl can be safely removed.

We still thank the original author Tony Monroe for the original version in Perl (dated 2000),
and Evan Priestley for the re-implementation in PHP.

Probably nobody knows about this feature. This may change in the future. See T15401.

Closes T15418

Test Plan:
Try some awesome cows to verify that everything still works. For instance:

```
cowsay {{{
 hello
}}}
```

```
cowsay (think=yes,eyes=XX,tongue=^^) {{{
 hello
}}}
```

```
cowsay (cow=stegosaurus) {{{
 hello
}}}
```

If nothing explodes, yuppie! Cowsay still works.

Credits to the original version in Perl remained in place.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15418

Differential Revision: https://we.phorge.it/D25242
2023-05-29 09:13:44 +02:00
epriestley
c705c8011e Use PHP implementation of Cowsay for cowsay rule
Summary:
Ref T7785. Convert the Cowsay Remarkup rule to use a PHP implementation so we don't have to execute an external `cowsay` binary.

I removed some of the default ".cow" files that come with Cowsay because they:

  - include Perl code which we can not interpret; or
  - are primarily in-jokes or standalone visual puns or artwork rather than usable actors on the grand stage of cowsay; or
  - offended my delicate sensibilities.

Users can add new cows to `resources/cows/custom/` if they want to make new cows available.

I have included a majestic original artwork depicting the "Companion Cube" character from //Portal//.

Test Plan: {F802535}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9408, T7785

Differential Revision: https://secure.phabricator.com/D14100
2015-09-13 12:27:30 -07:00