1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 08:06:13 +01:00
Commit graph

5 commits

Author SHA1 Message Date
epriestley
8410a8019a Fix tab-focus of Tokenizers
Summary: Fixes T3140. Previously, we added the highlight class only on explicit events, but not on actual focus events (e.g., via tab).

Test Plan: Tabbed into a tokenizer. Clicked a tokenizer. Tabbed out of a tokenizer. Clicked out of a tokenizer. Shift-tabbed out of a tokenizer. Verified highlight state was always correct.

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3140

Differential Revision: https://secure.phabricator.com/D5891
2013-05-10 10:23:32 -07:00
epriestley
c87ff2622b Apply D5832 to Phabricator
Summary: Brings the Javelin change in D5832 into Phabricator.

Test Plan: Hit a `/?&x` URI without hanging Safari.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5833
2013-05-06 07:24:00 -07:00
epriestley
897274eed6 Add a class to the Tokenizer container while it is focused
Summary: For some evil design purpose.

Test Plan: Focused, blurred tokenizers.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5780
2013-04-25 08:51:27 -07:00
Bob Trahan
58e35518b6 Hovercards - make 'em work a bit better
Summary:
this diff makes hovercards load and draw but a single time as appropos; pre-diff we could hammer the server by moving the mouse a bunch before the initial load and the re-draw event was continuously firing.

also makes hovercards work inside whacked out divs like the Conpherence message panel. Fixes T2949.

Test Plan: played with conpherence and phriction, observing hovercards showing up like they should

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: AnhNhan, aran, Korvin

Maniphest Tasks: T2949

Differential Revision: https://secure.phabricator.com/D5719
2013-04-16 18:25:25 -07:00
epriestley
95f57756aa Move all external JS into webroot/rsrc/externals
Summary:
Currently, Celerity map rebuilds on Windows don't put Stripe or Raphael into the map. Move them into `webroot/rsrc/externals/` so they get picked up.

At some point we should maybe let the mapper load resources from mulitple locations, but this is more straightforward for now.

See https://github.com/facebook/phabricator/issues/294

Test Plan: Rebuilt map, verified Burnup Rate + Stripe work.

Reviewers: vrana, btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5661
2013-04-11 10:06:05 -07:00