4 commits

Author	SHA1	Message	Date
epriestley	2a3783cd2c	Suggest "apc.slam_defense" off and "apc.write_lock" on ... Summary: Ref T5501. These settings reduce error log noise. Test Plan: Faked into this branch and hit the warning. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5501 Differential Revision: https://secure.phabricator.com/D12319	2015-04-08 11:31:19 -07:00
epriestley	ffe9c26b00	Emit cache setup issues from cache specs ... Summary: Ref T5501. Currently, we emit some bad warnings about, e.g., "apc.stat" on PHP 5.5+ systems with OPcache, where the warnings are not relevant. Generate and raise warnings out of the CacheSpec pipeline so we only run relevant code. Test Plan: Faked various warnings and saw them render correctly. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5501 Differential Revision: https://secure.phabricator.com/D12318	2015-04-08 11:31:01 -07:00
epriestley	c5d38c6e08	Provide more information about cache sizing in cache diagnostics ... Summary: Ref T5501. This expands cache information a little more. Test Plan: {F362975} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5501 Differential Revision: https://secure.phabricator.com/D12316	2015-04-07 15:08:47 -07:00
epriestley	0880788bd4	Restructure cache checks to improve modularity ... Summary: Ref T5501. This code was headed down a bad road; dump an indirection layer between rendering and data gatehring. In particular, this will make it much easier to lift these issues into setup warnings eventually. Test Plan: Viewed cache status page. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5501 Differential Revision: https://secure.phabricator.com/D12315	2015-04-07 14:38:03 -07:00