3 commits

Author	SHA1	Message	Date
Joshua Spence	3cf9a5820f	Minor formatting changes ... Summary: Apply some autofix linter rules. Test Plan: `arc lint` and `arc unit` Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D10585	2014-10-08 08:39:49 +11:00
epriestley	3e9a988cd7	Fix an incorrect filtering of groupless results from Maniphest "Group By" query ... Summary: Fixes T5081. This block enforces policies and prevents you from seeing groups associated with projects you can't see. However, it incorrectly removes tasks which end up with no group key. This can happen in two cases: - The task isn't in a project. - The task is in a project, but the query includes an "In All Projects: <that project>" constraint. In that case, we don't show the group becuase it would always contain every task. Test Plan: Replicated the setup in T5081, saw an "Ungrouped" group with "Task A": {F155766} Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T5081 Differential Revision: https://secure.phabricator.com/D9152	2014-05-16 08:47:06 -07:00
epriestley	e5e95352c7	Move Maniphest list rendering to SearchEngine ... Summary: Ref T4986. Moves Maniphest over. Nothing tricky here, just a complex block of rendering. Test Plan: Viewed Maniphest list. Created Maniphest panel. Used batch editor, drag-and-drop. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4986 Differential Revision: https://secure.phabricator.com/D9139	2014-05-15 19:17:38 -07:00