setRequireSecureBrowsing($secure_only); } protected function getLoginIcon() { return 'Facebook'; } public function isEnabled() { return parent::isEnabled() && PhabricatorEnv::getEnvConfig('facebook.auth-enabled'); } protected function getOAuthClientID() { return PhabricatorEnv::getEnvConfig('facebook.application-id'); } protected function getOAuthClientSecret() { $secret = PhabricatorEnv::getEnvConfig('facebook.application-secret'); if ($secret) { return new PhutilOpaqueEnvelope($secret); } return null; } public function shouldAllowLogin() { return true; } public function shouldAllowRegistration() { return PhabricatorEnv::getEnvConfig('facebook.registration-enabled'); } public function shouldAllowAccountLink() { return true; } public function shouldAllowAccountUnlink() { return !PhabricatorEnv::getEnvConfig('facebook.auth-permanent'); } public function readFormValuesFromProvider() { $require_secure = PhabricatorEnv::getEnvConfig( 'facebook.require-https-auth'); // TODO: When we read from config, default this on for new providers. return parent::readFormValuesFromProvider() + array( self::KEY_REQUIRE_SECURE => $require_secure, ); } public function readFormValuesFromRequest(AphrontRequest $request) { return parent::readFormValuesFromRequest($request) + array( self::KEY_REQUIRE_SECURE => $request->getBool(self::KEY_REQUIRE_SECURE), ); } public function extendEditForm( AphrontRequest $request, AphrontFormView $form, array $values, array $issues) { parent::extendEditForm($request, $form, $values, $issues); $key_require = self::KEY_REQUIRE_SECURE; $v_require = idx($values, $key_require); $form ->appendChild( id(new AphrontFormCheckboxControl()) ->addCheckbox( $key_require, $v_require, pht( "%s ". "Require users to enable 'secure browsing' on Facebook in order ". "to use Facebook to authenticate with Phabricator. This ". "improves security by preventing an attacker from capturing ". "an insecure Facebook session and escalating it into a ". "Phabricator session. Enabling it is recommended.", hsprintf( '%s', pht('Require Secure Browsing:'))))); } public function renderConfigPropertyTransactionTitle( PhabricatorAuthProviderConfigTransaction $xaction) { $author_phid = $xaction->getAuthorPHID(); $old = $xaction->getOldValue(); $new = $xaction->getNewValue(); $key = $xaction->getMetadataValue( PhabricatorAuthProviderConfigTransaction::PROPERTY_KEY); switch ($key) { case self::KEY_REQUIRE_SECURE: if ($new) { return pht( '%s turned "Require Secure Browsing" on.', $xaction->renderHandleLink($author_phid)); } else { return pht( '%s turned "Require Secure Browsing" off.', $xaction->renderHandleLink($author_phid)); } } return parent::renderConfigPropertyTransactionTitle($xaction); } }