mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-09 16:32:39 +01:00
29fd3f136b
Summary: Ref T6840. This feels a little dirty; open to alternate suggestions. We currently have a race condition where multiple daemons may load a commit and then save it at the same time, when processing "reverts X" text. Prior to this feature, two daemons would never load a commit at the same time. The "reverts X" load/save has no effect (doesn't change any object properties), but it will set the state back to the loaded state on save(). This overwrites any flag updates made to the commit in the meantime, and can produce the race in T6840. In other cases (triggers, harbormaster, repositories) we deal with this kind of problem with "append-only-updates + single-consumer", or a bunch of locking. There isn't really a good place to add a single consumer for commits, since a lot of daemons need to access them. We could move the flags column to a separate table, but this feels pretty complicated. And locking is messy, also mostly because we have so many consumers. Just exempting this column (which has unusual behavior) from `save()` feels OK-ish? I don't know if we'll have other use cases for this, and I like it even less if we never do, but this patch is pretty small and feels fairly understandable (that said, I also don't like that it can make some properties just silently not update if you aren't on the lookout). So, this is //a// fix, and feels simplest/least-bad for the moment to me, I thiiink. Test Plan: Added and executed unit tests. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6840 Differential Revision: https://secure.phabricator.com/D11822
2 lines
122 B
SQL
2 lines
122 B
SQL
ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_scratchtable
|
|
ADD nonmutableData VARCHAR(64) COLLATE {$COLLATE_TEXT};
|