1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-16 15:28:48 +02:00
phorge-phorge/scripts/ssh
Valerio Bozzolan 96ae4ba13a PHP 8.1: fixes for strlen() not accepting NULL anymore, part 2
Summary:
This is a fix for PHP 8.1 deprecation of strlen(NULL), for these Phorge components:

- scripts
- aphront
- project

The strlen() was used in Phabricator to check if a generic value was a non-empty string.
For this reason, Phorge adopts phutil_nonempty_string() that checks that.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If your phutil_nonempty_string() throws an exception, just
report it to Phorge to evaluate and fix together that specific corner case.

Closes T15223
Ref T15190
Ref T15064

Test Plan: - check with your big eyes that there are no obvious typos

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15223, T15190, T15064

Differential Revision: https://we.phorge.it/D25105
2023-04-01 15:20:13 +02:00
..
ssh-auth.php PHP 8.1: fixes for strlen() not accepting NULL anymore, part 2 2023-04-01 15:20:13 +02:00
ssh-connect.php Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator 2021-07-21 10:21:06 -07:00
ssh-exec.php PHP 8.1: fixes for strlen() not accepting NULL anymore, part 2 2023-04-01 15:20:13 +02:00