1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-12 04:15:00 +01:00
phorge-phorge/src/applications/flag
Andre Klapper 43539b220c Remove trivial cases of unreachable code
Summary:
Static code analysis can detect `Unreachable statement - code above always terminates.`
The vast majority of occurrences in the Phorge codebase are due to an unreachable `break` within a `case` after a `return` or after an all-covering `if/else`.
All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases.

Test Plan: Examine the code; run static code analysis.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25802
2024-09-04 12:17:28 +02:00
..
application Remove counts from home navigation 2017-01-21 13:55:40 -08:00
conduit phtize all the things 2015-05-22 21:16:39 +10:00
constants Extend from Phobject 2015-06-15 18:02:27 +10:00
controller Update Flag for handleRequest 2015-07-29 17:00:31 -07:00
customfield Add (Advanced) Custom Fields to Item List 2024-05-11 13:25:41 +03:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
events Replace Sprite-Icons with FontAwesome 2014-05-12 10:08:32 -07:00
herald Add a "Remove flag" action to Herald 2019-09-09 13:15:52 -07:00
interface Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
query Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
view Fix method visibility for AphrontFormControl methods 2015-01-07 07:33:37 +11:00