mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-24 07:42:40 +01:00
3ec4984f27
Summary: Ref T603. Ref T2625. Use cursors to page Differential queries, not offsets. The trick here is that some queries are ordered. In these cases, we either need to pass some kind of tuple or do a cursor lookup. For example, if you are viewing revisions ordered by `dateModified`, we can either have the next page be something like: ?afterDateModified=2398329373&afterID=292&order=modified ...or some magical token: ?afterToken=2398329373:292&order=modified I think we did this in Conpherence, but one factor there was that paging orders update with some frequency. In most cases, I think it's reasonable to pass just the ID and do a lookup to get the actual clause value (e.g., go look up object ID 292 and see what its dateModified is) and I think this is much simpler in general. Test Plan: Set page size in Differential to 3, and paged through result lists ordered by date created and date modified. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603, T2625 Differential Revision: https://secure.phabricator.com/D6345 |
||
|---|---|---|
| .. | ||
| policy | ||
| PhabricatorEmptyQueryException.php | ||
| PhabricatorOffsetPagedQuery.php | ||
| PhabricatorQuery.php | ||