1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 09:48:47 +02:00
phorge-phorge/src/view
epriestley 1a001ca033 Render ApplicationSearch errors correctly
Summary:
Fixes T8774. When an ApplicationSearch page returned an error (e.g., using a "viewer()" query while logged out), we would try to add action links to a box without a header. Instead:

  - If a box has no header, but has show/hide actions, just create an empty header so the view renders. This is a little silly looking but does what the caller asks.
  - Always set the title on the result box, so we get a header.

Test Plan: Did an invalid (logged out, with viewer()) search. Did a valid search.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T8774

Differential Revision: https://secure.phabricator.com/D13576
2015-07-07 11:52:06 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
control Merge branch 'master' into redesign-2015 2015-06-15 08:06:23 -07:00
form [Redesign] Clean up <select> 2015-07-02 14:25:45 -07:00
layout Merge branch 'master' into redesign-2015 2015-06-19 08:33:30 -07:00
page [Redesign] Swap Slabo for Roboto Slab 2015-06-25 09:20:51 -07:00
phui Render ApplicationSearch errors correctly 2015-07-07 11:52:06 -07:00
widget Merge branch 'master' into redesign-2015 2015-06-10 07:44:58 -07:00
AphrontDialogView.php [Redesign] Clean up AphrontDialog 2015-06-29 12:49:21 -07:00
AphrontJavelinView.php Various linter fixes 2015-05-20 07:27:41 +10:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Improve handle loading semantics for tokenizers 2015-04-02 13:42:01 -07:00
AphrontView.php Desktop Notification support 2015-06-22 13:11:37 -07:00
viewutils.php Force date/time preferences to valid values 2015-06-18 15:11:01 -07:00