1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 09:48:47 +02:00
phorge-phorge/src
epriestley 005d8493b0 Pass GIT_ENVIRONMENTAL_MAGIC through to hook subprocesses to support Git 2.11.0
Summary:
Fixes T11940. In 2.11.0, Git has made a change so that newly-pushed changes are held in a temporary area until the hook accepts or rejects them.

This magic temporary area is only readable if the appropriate `GIT_ENVIRONMENTAL_MAGIC` variables are available. When executing `git` commands, pass them through from the calling context.

We're intentionally conservative about which variables we pass, and with good reason (see "httpoxy" in T11359). I think this continues to be the correct default behavior.

Test Plan:
  - Upgraded to Git 2.11.0.
  - Tried to push over SSH, got a hook error.
  - Applied patch.
  - Pulled and pushed over SSH.
  - Pulled and pushed over HTTP.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11940

Differential Revision: https://secure.phabricator.com/D16988
2016-12-05 12:45:30 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Normalize remote IP addresses when writing to logs, etc 2016-12-05 11:20:29 -08:00
applications Pass GIT_ENVIRONMENTAL_MAGIC through to hook subprocesses to support Git 2.11.0 2016-12-05 12:45:30 -08:00
docs Allow persistent connections to be configured per database host 2016-11-22 10:55:45 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Normalize remote IP addresses when writing to logs, etc 2016-12-05 11:20:29 -08:00
view Prevent double lightbox in lightbox comments 2016-12-02 10:56:21 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Add "Manual Activities", to tell administrators to rebuild the search index 2016-11-30 11:23:54 -08:00