mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
0139fb9178
Summary:
Currently we have this:
- DiffusionController (abstract, has some random shared browse code)
- DiffusionBrowseController (concrete, Handles routing, directories, and search)
- DiffusionBrowseFileController (concrete, handles files)
Instead, do this:
- DiffusionController (no browse-related code)
- DiffusionBrowseController (abstract, shared browse code)
- DiffusionBrowseMainController (concrete, handles routing)
- DiffusionBrowseDirectoryController (concrete, handles directories)
- DiffusionBrowseFileController (concrete, handles files)
- DiffusionBrowseSearchController (concrete, handles search)
Feels a lot cleaner.
Test Plan: Looked at directories, searches, and files.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7045
39 lines
1.3 KiB
PHP
39 lines
1.3 KiB
PHP
<?php
|
|
|
|
final class DiffusionBrowseMainController extends DiffusionBrowseController {
|
|
|
|
public function processRequest() {
|
|
$drequest = $this->diffusionRequest;
|
|
$request = $this->getRequest();
|
|
|
|
// Figure out if we're browsing a directory, a file, or a search result
|
|
// list. Then delegate to the appropriate controller.
|
|
|
|
$search = $request->getStr('grep');
|
|
if (strlen($search)) {
|
|
$controller = new DiffusionBrowseSearchController($request);
|
|
} else {
|
|
$results = DiffusionBrowseResultSet::newFromConduit(
|
|
$this->callConduitWithDiffusionRequest(
|
|
'diffusion.browsequery',
|
|
array(
|
|
'path' => $drequest->getPath(),
|
|
'commit' => $drequest->getCommit(),
|
|
)));
|
|
$reason = $results->getReasonForEmptyResultSet();
|
|
$is_file = ($reason == DiffusionBrowseResultSet::REASON_IS_FILE);
|
|
|
|
if ($is_file) {
|
|
$controller = new DiffusionBrowseFileController($request);
|
|
} else {
|
|
$controller = new DiffusionBrowseDirectoryController($request);
|
|
$controller->setBrowseQueryResults($results);
|
|
}
|
|
}
|
|
|
|
$controller->setDiffusionRequest($drequest);
|
|
$controller->setCurrentApplication($this->getCurrentApplication());
|
|
return $this->delegateToController($controller);
|
|
}
|
|
|
|
}
|