revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Bob Trahan 9838251515 Make PhabricatorActionListView logged-out user savvy 
Summary:
Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI.

Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption.

Test Plan: played around with a mock all logged out (Ref T2652) and it worked!

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2691

Differential Revision: https://secure.phabricator.com/D6416
2013-07-12 11:39:47 -07:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Use PHUIIconView for PhabricatorActionView 2013-07-10 12:33:51 -07:00
auth Modernize email verification page 2013-07-10 18:53:09 -07:00
base Provide contextual help on auth provider configuration 2013-06-20 11:18:48 -07:00
cache Provide 'bin/cache', for managing caches 2013-05-20 10:16:35 -07:00
calendar Conpherence calendar updates 2013-05-29 14:35:34 -07:00
chatlog Consolidate some datetime code and add unit tests 2013-06-03 12:58:11 -07:00
conduit Provide PhabricatorSavedQuery to renderResultsList() 2013-07-03 05:46:04 -07:00
config Add a "disabled" style 2013-07-12 11:31:20 -07:00
conpherence Unbeta Conpherence 2013-07-12 09:58:27 -07:00
countdown Simplify and generalize remarkup engine construction 2013-07-09 16:23:33 -07:00
daemon Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
differential Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
diffusion Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
directory/controller Minor, fix some margins on the homepage directory view. 2013-07-03 06:24:46 -07:00
diviner Simplify and generalize remarkup engine construction 2013-07-09 16:23:33 -07:00
doorkeeper Add a link to the main Asana task from Differential 2013-07-09 16:22:33 -07:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
fact Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
feed Allow Feed HTTP hooks to be https:// 2013-07-08 09:26:21 -07:00
files Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
flag Use ActionListView for all profile actions 2013-07-10 05:11:08 -07:00
harbormaster Add HarbormasterRunnerWorker, for running CI tests 2012-12-17 13:43:26 -08:00
help/controller Some help pht 2013-05-21 15:29:21 -07:00
herald PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
legalpad Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
lipsum Files Generating 2013-05-06 10:30:38 -07:00
macro Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
mailinglists PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
maniphest Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
meta Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
metamta Move outbound mail lists to CLI and enhance details 2013-07-10 18:52:22 -07:00
notification Fix weird "0" notification numbers 2013-05-21 15:44:44 -07:00
oauthserver Initialize used variable 2013-07-09 21:55:27 -07:00
owners PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
paste Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
people Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
phame Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
phid Conpherence - make threads loadable as handles 2013-07-03 16:46:33 -07:00
phlux Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
pholio Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
phortune Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
phpast Uninstall Conduit calls when uninstalling applications 2013-03-13 07:09:05 -07:00
phrequent Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
phriction Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
policy Fix typo in variable name 2013-07-10 08:25:40 -07:00
ponder Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
project Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
releeph Always provide a viewer when executing DifferentialRevisionQuery 2013-07-01 12:38:27 -07:00
remarkup/conduit Convert Remarkup to safe HTML 2013-02-13 12:34:49 -08:00
repository Phabricator event timeline removed 2013-07-09 18:07:42 -07:00
search Add a "disabled" style 2013-07-12 11:31:20 -07:00
settings Merge "Profile" and "Account" settings panels 2013-07-10 05:09:50 -07:00
slowvote PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
subscriptions Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
system Add a user-accessible hook for dumping debug code into an install 2013-03-04 13:45:51 -08:00
tokens Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
transactions Make ApplicationTransactions preview -> submit flow less janky 2013-06-24 15:41:59 -07:00
typeahead Showing tasks & diffs in the typeahead. 2013-07-08 09:50:08 -07:00
uiexample Make PhabricatorActionListView logged-out user savvy 2013-07-12 11:39:47 -07:00
xhprof Fix XHProf index page 2013-04-02 09:52:52 -07:00