1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/config/controller
epriestley 96839d35f4 Detect and raise setup warnings from within Phabricator
Summary:
This is basicaly a light version of D4286. The major problem with D4286 is that it's a huge leap and completely replaces the setup process in one step.

Instead, I want to do this:

  - Add the post-setup warnings (yellow bar with "6 unresolved warnings...").
  - Copy all setup checks into post-setup warnings (so every check has an old-style check and a new-style check).
  - Run that for a little bit and make sure it's stable.
  - Implement fatal post-setup checks (the red screen, vs the yellow bar).
  - Run that for a little bit.
  - Nuke setup mode and delete all the old checks.

This should give us a bunch of very gradual steps toward the brave new world of simpler setup.

Test Plan:
 - Faked APC setup failures, saw warnings raise.
 - Verified that this runs after restart (get + set).
 - Verified that this costs us only one cache hit after first-run (get only).

Reviewers: btrahan, codeblock, vrana, chad

Reviewed By: codeblock

CC: aran

Maniphest Tasks: T2228

Differential Revision: https://secure.phabricator.com/D4295
2012-12-30 06:37:49 -08:00
..
PhabricatorConfigController.php Show the default value in Config. 2012-12-28 11:38:05 -08:00
PhabricatorConfigEditController.php Fix two bugs with Config's Edit controller. 2012-12-30 06:15:51 -08:00
PhabricatorConfigIssueListController.php Detect and raise setup warnings from within Phabricator 2012-12-30 06:37:49 -08:00
PhabricatorConfigIssueViewController.php Detect and raise setup warnings from within Phabricator 2012-12-30 06:37:49 -08:00
PhabricatorConfigListController.php Start of a config web interface. 2012-12-27 15:21:21 -08:00