epriestley 930cc7a6dd Generalize Legalpad validation logic for "Require Signature" ... Summary: See downstream <https://phabricator.wikimedia.org/T208254>. I can't actually reproduce any issue here (we only show this field when creating a document, and only if the viewer is an administrator), so maybe this relied on some changes or was originally reported against older code. Regardless, the validation isn't quite right: it requires administrator privileges to apply this transaction at all, but should only require administrator privileges to change the value. Test Plan: Edited Legalpad documents as an administrator and non-administrator before and after the change, with and without signatures being required. Couldn't reproduce the original issue, but this version is generally more correct/robust. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20311		2019-03-25 11:26:13 -07:00
..
LegalpadDocumentPreambleTransaction.php	Add spelling TODOs	2017-10-09 11:56:53 -07:00
LegalpadDocumentRequireSignatureTransaction.php	Generalize Legalpad validation logic for "Require Signature"	2019-03-25 11:26:13 -07:00
LegalpadDocumentSignatureTypeTransaction.php	Clean up legalpad transaction copy	2017-05-09 10:47:24 -07:00
LegalpadDocumentTextTransaction.php	Clean up legalpad transaction copy	2017-05-09 10:47:24 -07:00
LegalpadDocumentTitleTransaction.php	Clean up legalpad transaction copy	2017-05-09 10:47:24 -07:00
LegalpadDocumentTransactionType.php	Update Legalpad to use modular transactions	2017-05-04 12:45:02 -07:00