1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-22 12:41:19 +01:00
phorge-phorge/src/applications/differential/xaction
epriestley 03ab7224bb Reduce STATUS_CLOSED (now internally "Published") revision status callsites
Summary:
Ref T2543. Add `isPublished()` to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces `isChangePlanned()`, which felt less awkward than `isChangesPlanned()` but more consistent than `hasChangesPlanned()` or `isStatusChangesPlanned()` or similar.

Test Plan: `grep`, loaded revisions, requested review.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18341
2017-08-09 11:05:42 -07:00
..
DifferentialRevisionAbandonTransaction.php Restore "[Action]" mail subject lines to Differential/Diffusion 2017-01-12 11:44:24 -08:00
DifferentialRevisionAcceptTransaction.php Don't consider accepting on behalf of valid-but-accepted reviewers to be a validation error 2017-05-25 14:30:19 -07:00
DifferentialRevisionActionTransaction.php When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox 2017-04-10 17:28:02 -07:00
DifferentialRevisionCloseTransaction.php Restore "[Action]" mail subject lines to Differential/Diffusion 2017-01-12 11:44:24 -08:00
DifferentialRevisionCommandeerTransaction.php Fix typo in DifferentialRevisionCommandeerTransaction 2017-01-30 12:23:07 -08:00
DifferentialRevisionPlanChangesTransaction.php Reduce STATUS_CLOSED (now internally "Published") revision status callsites 2017-08-09 11:05:42 -07:00
DifferentialRevisionReclaimTransaction.php Restore "[Action]" mail subject lines to Differential/Diffusion 2017-01-12 11:44:24 -08:00
DifferentialRevisionRejectTransaction.php Allow users to re-accept or re-reject a revision if they have authority over package/project reviewers not yet in the target state 2017-01-18 13:16:01 -08:00
DifferentialRevisionReopenTransaction.php Reduce STATUS_CLOSED (now internally "Published") revision status callsites 2017-08-09 11:05:42 -07:00
DifferentialRevisionRepositoryTransaction.php Add Summary and Repository EditEngine fields + Modular Transactions to Differential 2016-12-13 18:18:32 -08:00
DifferentialRevisionRequestReviewTransaction.php Reduce STATUS_CLOSED (now internally "Published") revision status callsites 2017-08-09 11:05:42 -07:00
DifferentialRevisionResignTransaction.php Allow users to resign if they have authority over any reviewer 2017-03-24 13:14:47 -07:00
DifferentialRevisionReviewersTransaction.php Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
DifferentialRevisionReviewTransaction.php Don't consider accepting on behalf of valid-but-accepted reviewers to be a validation error 2017-05-25 14:30:19 -07:00
DifferentialRevisionSummaryTransaction.php Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI 2017-01-25 13:07:30 -08:00
DifferentialRevisionTestPlanTransaction.php Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
DifferentialRevisionTitleTransaction.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialRevisionTransactionType.php Allow users to resign if they have authority over any reviewer 2017-03-24 13:14:47 -07:00
DifferentialRevisionVoidTransaction.php Don't downgrade accepts on update (fix "sticky accept") 2017-04-03 09:55:22 -07:00