1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/maniphest/controller
epriestley 0597aba33e Add hard stops on empty batch edit sets
Summary:
Ref T8637. If a user tries to batch edit a list of tasks which can't be edited, we fall through to `withIDs(array())`, which can affect //everything//.

Explicitly stop batch editing if we don't have valid IDs or valid tasks.

The UI sort-of warns you that something is wrong, but this is ultimately a pretty severe UX issue. I'll fix the underlying Query in the next diff.

Test Plan: Tried to batch edit a list of tasks I didn't have permission to edit.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: lloyd.oliver, epriestley

Maniphest Tasks: T8637

Differential Revision: https://secure.phabricator.com/D13388
2015-06-22 11:47:58 -07:00
..
ManiphestBatchEditController.php Add hard stops on empty batch edit sets 2015-06-22 11:47:58 -07:00
ManiphestController.php Fix mobile Maniphest Create link 2015-02-24 14:52:57 -08:00
ManiphestExportController.php phtize all the things 2015-05-22 21:16:39 +10:00
ManiphestReportController.php Mark some strings for translation 2015-06-09 23:06:52 +10:00
ManiphestSubpriorityController.php Fix literally thousands of drag-to-reorder priority bugs 2015-03-20 17:38:25 -07:00
ManiphestTaskDetailController.php Require TokenizerControl to always have a datasource 2015-04-20 10:06:13 -07:00
ManiphestTaskEditController.php Support Spaces in Maniphest 2015-06-10 15:53:04 -07:00
ManiphestTaskListController.php Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
ManiphestTransactionPreviewController.php Use phutil_json_decode instead of json_decode 2015-05-05 20:48:55 +10:00
ManiphestTransactionSaveController.php phtize all the things 2015-05-22 21:16:39 +10:00