mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-23 02:38:48 +02:00
0be3db03ee
Summary:
I think this is the last major step -- use the fields to parse commit messages,
not a hard-coded list of stuff. This adds two primary methods to fields, one to
get all the labels they'll parse (so we can do "CC" and "CCs" and treat them as
the same field) and one to parse the string into a canonical representation
(e.g., lookup reviewers and such).
You'll need to impelement the one block of task-specific stuff I removed in
Facebook's task field:
list($pre_comment) = split(' -- ', $data);
$data = array_filter(preg_split('/[^\d]+/', $pre_comment));
foreach ($data as $k => $v) {
$data[$k] = (int)$v;
}
$data = array_unique($data);
break;
Otherwise I think this is clean.
Test Plan:
- Called the conduit method with various commit messages, parsed fields/errors
seemed correct.
- "arc diff"'d this diff onto localhost, then updated it.
- "arc amend"'d this diff.
Reviewers: jungejason, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason, epriestley
Differential Revision: 829
|
||
|---|---|---|
| .. | ||
| applypatch | ||
| arcanistproject | ||
| author | ||
| base | ||
| blamerev | ||
| ccs | ||
| commits | ||
| dependencies | ||
| exportpatch | ||
| gitsvnid | ||
| host | ||
| lines | ||
| lint | ||
| maniphesttasks | ||
| path | ||
| revertplan | ||
| reviewedby | ||
| reviewers | ||
| revisionid | ||
| revisionstatus | ||
| summary | ||
| testplan | ||
| title | ||
| unit | ||