1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/herald/action
epriestley 4fa99374be Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it
Summary:
See <https://discourse.phabricator-community.org/t/herald-webhook-is-not-called-but-herald-transcript-tells-me-the-opposite/1098>.

The "Commit Hook" events don't operate on objects and don't use TransactionEditors. They can't call webhooks in a normal way and currently don't call webhooks at all. Stop offering these actions in the UI.

The  "Outbound Mail" event also fires oddly and likely doesn't make much sense to hook anyway.

Test Plan: Verified that these events no longer offer "Call webhooks", while normal events still do.

Differential Revision: https://secure.phabricator.com/D19061
2018-02-11 06:15:29 -08:00
..
HeraldAction.php Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
HeraldActionGroup.php Use getPhobjectClassConstant() to access class constants 2015-10-01 16:56:21 -07:00
HeraldApplicationActionGroup.php Modularize Maniphest Herald "Assign Task" action 2015-08-03 14:33:25 -07:00
HeraldCallWebhookAction.php Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
HeraldCommentAction.php Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
HeraldDoNothingAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
HeraldNotifyActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
HeraldPreventActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
HeraldSupportActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
HeraldUtilityActionGroup.php Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00