epriestley 073cb0e78c Make PhabricatorPolicyInterface require a getPHID() method ... Summary: Ref T603. This cleans up an existing callsite in the policy filter, and opens up some stuff in the future. Some policy objects don't have real PHIDs: PhabricatorTokenGiven PhabricatorSavedQuery PhabricatorNamedQuery PhrequentUserTime PhabricatorFlag PhabricatorDaemonLog PhabricatorConduitMethodCallLog ConduitAPIMethod PhabricatorChatLogEvent PhabricatorChatLogChannel Although it would be reasonable to add real PHIDs to some of these (like `ChatLogChannel`), it probably doesn't make much sense for others (`DaemonLog`, `MethodCallLog`). Just let them return `null`. Also remove some duplicate `$id` and `$phid` properties. These are declared on `PhabricatorLiskDAO` and do not need to be redeclared. Test Plan: Ran the `testEverythingImplemented` unit test, which verifies that all classes conform to the interface. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7306		2013-10-14 14:35:47 -07:00
..
PhabricatorPolicyAwareTestQuery.php	Introduce PhabricatorEmptyQueryException	2013-03-06 19:22:00 -08:00
PhabricatorPolicyDataTestCase.php	Rename ACTION_ACCEPT into ACTION_ALLOW	2013-10-14 12:05:11 -07:00
PhabricatorPolicyTestCase.php	Treat invalid policies as broadly similar to "no one"	2013-10-01 11:25:30 -07:00
PhabricatorPolicyTestObject.php	Make PhabricatorPolicyInterface require a getPHID() method	2013-10-14 14:35:47 -07:00