epriestley 682e0aa468 Add "responsible users" and "subscribers" to DifferentialRevisionQuery, plus a ... couple bug fixes Summary: - Add the ability to query for "responsible users" (author or reviewer). - Add the ability to query for "subscribers" (reviewer or CC). - Fix an issue where CC and Reviewer used the same join table alias and were incompatible. - Remove support for 'paths' for the moment, since each path needs a repository ID. (There are no clients for this.) - Remove single withX() methods that have no callsites -- withPath() is singular because it accepts two arguments and I didn't want to have an ad-hoc type format, but I think we can get away without these for other conditions. - Include GROUP BY in more cases where may need it. This doesn't actually change program behavior since we uniquify in loadFromArray(), it just means less data over the wire. These new query classes are to support rewriting the Differential list view on top of DifferentialRevisionQuery. Test Plan: - Issued queries via conduit for "responsible users". - Issued queries via conduit for "subscribers". - Issued queries via conduit for "cc" with "reviewer" at the same time. - Issued queries via conduit for "cc", "reviewer", "responsible users" and "subscribers" at the same time. - Issued a "subscribers" and "reviewers" query which returned duplicates; verified GROUP BY took effect. Reviewers: nh, btrahan, jungejason Reviewed By: nh CC: aran, nh Differential Revision: 1182		2011-12-08 09:38:52 -08:00
..
revision	Add "responsible users" and "subscribers" to DifferentialRevisionQuery, plus a	2011-12-08 09:38:52 -08:00