epriestley ab579f2511 Never generate file download forms which point to the CDN domain, tighten "form-action" CSP ... Summary: Depends on D19155. Ref T13094. Ref T4340. We can't currently implement a strict `form-action 'self'` content security policy because some file downloads rely on a `<form />` which sometimes POSTs to the CDN domain. Broadly, stop generating these forms. We just redirect instead, and show an interstitial confirm dialog if no CDN domain is configured. This makes the UX for installs with no CDN domain a little worse and the UX for everyone else better. Then, implement the stricter Content-Security-Policy. This also removes extra confirm dialogs for downloading Harbormaster build logs and data exports. Test Plan: - Went through the plain data export, data export with bulk jobs, ssh key generation, calendar ICS download, Diffusion data, Paste data, Harbormaster log data, and normal file data download workflows with a CDN domain. - Went through all those workflows again without a CDN domain. - Grepped for affected symbols (`getCDNURI()`, `getDownloadURI()`). - Added an evil form to a page, tried to submit it, was rejected. - Went through the ReCaptcha and Stripe flows again to see if they're submitting any forms. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13094, T4340 Differential Revision: https://secure.phabricator.com/D19156		2018-02-28 17:20:12 -08:00
..
__tests__	Tell users to "Wait Patiently" for admin account verification later in the registration process	2017-11-28 10:00:03 -08:00
Phabricator404Controller.php	After writing "next_uri", don't write it again for a while	2014-01-23 14:16:08 -08:00
PhabricatorController.php	Never generate file download forms which point to the CDN domain, tighten "form-action" CSP	2018-02-28 17:20:12 -08:00
PhabricatorRedirectController.php	Update RedirectController for handleRequest	2016-09-19 13:24:01 -04:00