1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 17:28:51 +02:00
phorge-phorge/webroot/rsrc/js/application
epriestley 081163ab6d Simplify side nav CSS and fix various glitches
Summary:
Fixes glitches in the side nav. Resolves T1828. Resolves T2156.

  - Elastic scrolling (T2156): in Safari on OSX, using a scroll touch on the trackpad to scroll up past the top of the document caused newer-style side menus to scroll down, leaving a visible whitespace bar.
  - Whitespace glitch: Particularly in Safari, scrolling down the document quickly from the top caused the top menu to scroll away before the side menu rose to meet it. Use a fixed background color bar that extends under the menu so this doesn't happen.
  - Use of "!important": use CSS better so we don't need to "!important" things.
  - Dark Console (T1828): Instead of hard-coding the top position, determine it dynamically by looking at where the content is. This also fixes the menu overlapping with the red "there are errors on this page" development bar.
  - General "fixed" glitchiness: don't use fixed-position for menu content other than flexible (draggable) menus.

Test Plan:
  - Viewed and scrolled menus in Paste. Opened and closed DarkConsole. Switched devices.
  - Viewed and scrolled flexible menus in Differential and Diffusion. Opened and closed DarkConsole. Switched devices.

Reviewers: vrana, chad, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1828, T2156

Differential Revision: https://secure.phabricator.com/D4185
2012-12-14 15:14:14 -08:00
..
aphlict Improve style of notifications 2012-12-07 16:26:43 -08:00
core Simplify side nav CSS and fix various glitches 2012-12-14 15:14:14 -08:00
countdown Make countdowns (internally) embeddable 2012-08-14 19:19:23 -07:00
differential Better explain 'h' keyboard shortcut in Differential 2012-11-06 11:50:31 -08:00
diffusion Highlight lines on drag and drop in Diffusion 2012-08-05 18:56:25 -07:00
herald Allow users to add flags via Herald rules 2012-03-30 13:51:54 -07:00
maniphest Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
owners Allow excluding paths from package 2012-12-07 16:33:16 -08:00
phame Modernize blog UI 2012-10-15 14:50:12 -07:00
phortune For discussion -- Stripe integration 2012-04-04 16:09:29 -07:00
phriction Add a document preview to Phriction 2011-07-16 18:48:27 -07:00
ponder Simplify upvote/downvote implementation 2012-09-30 20:12:35 -07:00
projects Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
repository Don't open symbols on double click 2012-09-17 16:08:53 -07:00
transactions Render application transactions via Ajax 2012-12-11 14:02:29 -08:00
uiexample Improve the implementation of Notifications 2012-10-08 15:22:29 -07:00