mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-20 09:18:48 +02:00
08126d3904
Summary: Fixes T6692. Addresses two main issues: - The write guard would sometimes not get disposed of on exception pathways, generating an unnecessary secondary error which was just a symptom of the original root error. - This was generally confusing and reduced the quality of reports we received because users would report the symptomatic error sometimes instead of the real error. - Instead, reflow the handling so that we always dispose of the write guard if we create one. - If we missed the Controller-level error page generation (normally, a nice page with full CSS, etc), we'd jump straight to Startup-level error page generation (very basic plain text). - A large class of errors occur too early or too late to be handled by Controller-level pages, but many of these errors are not fundamental, and the plain text page is excessively severe. - Provide a mid-level simple HTML error page for errors which can't get full CSS, but also aren't so fundamental that we have no recourse but plain text. Test Plan: Mid-level errors now produce an intentional-looking error page: {F259885} Verified that setup errors still render properly. @chad, feel free to tweak the exception page -- I just did a rough pass on it. Like the setup error stuff, it doesn't have Celerity, so we can't use `{$colors}` and no other CSS will be loaded. Reviewers: chad, btrahan Reviewed By: btrahan Subscribers: epriestley, chad Maniphest Tasks: T6692 Differential Revision: https://secure.phabricator.com/D11126
27 lines
467 B
CSS
27 lines
467 B
CSS
/**
|
|
* @provides unhandled-exception-css
|
|
*/
|
|
|
|
.unhandled-exception {
|
|
background: #222228;
|
|
}
|
|
|
|
.unhandled-exception-detail {
|
|
max-width: 760px;
|
|
margin: 16px auto;
|
|
background: #f7f7f7;
|
|
border: 2px solid #ffffff;
|
|
}
|
|
|
|
.unhandled-exception-detail .unhandled-exception-title {
|
|
font-size: 15px;
|
|
font-weight: bold;
|
|
margin: 0;
|
|
padding: 16px;
|
|
background: #DFE0E2;
|
|
}
|
|
|
|
.unhandled-exception-detail .unhandled-exception-body {
|
|
padding: 16px;
|
|
color: #4B4D51;
|
|
}
|