mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
082b7f95e6
Summary: Ref T1460. Track and store which comments are threaded replies to other comments, vs merely appearing on the same lines. This doesn't actually write `hasReplies` yet, since that needs to happen when we un-draft comments on submission. Test Plan: Made inline comments in Differential and Diffusion, including replies. Replies were marked as "Is Reply". Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T1460 Differential Revision: https://secure.phabricator.com/D12017
91 lines
2.2 KiB
PHP
91 lines
2.2 KiB
PHP
<?php
|
|
|
|
final class DiffusionInlineCommentController
|
|
extends PhabricatorInlineCommentController {
|
|
|
|
private $commitPHID;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->commitPHID = $data['phid'];
|
|
}
|
|
|
|
protected function createComment() {
|
|
|
|
// Verify commit and path correspond to actual objects.
|
|
$commit_phid = $this->commitPHID;
|
|
$path_id = $this->getChangesetID();
|
|
|
|
$commit = id(new PhabricatorRepositoryCommit())->loadOneWhere(
|
|
'phid = %s',
|
|
$commit_phid);
|
|
if (!$commit) {
|
|
throw new Exception('Invalid commit ID!');
|
|
}
|
|
|
|
// TODO: Write a real PathQuery object?
|
|
|
|
$path = queryfx_one(
|
|
id(new PhabricatorRepository())->establishConnection('r'),
|
|
'SELECT path FROM %T WHERE id = %d',
|
|
PhabricatorRepository::TABLE_PATH,
|
|
$path_id);
|
|
|
|
if (!$path) {
|
|
throw new Exception('Invalid path ID!');
|
|
}
|
|
|
|
return id(new PhabricatorAuditInlineComment())
|
|
->setCommitPHID($commit_phid)
|
|
->setPathID($path_id);
|
|
}
|
|
|
|
protected function loadComment($id) {
|
|
return PhabricatorAuditInlineComment::loadID($id);
|
|
}
|
|
|
|
protected function loadCommentByPHID($phid) {
|
|
return PhabricatorAuditInlineComment::loadPHID($phid);
|
|
}
|
|
|
|
protected function loadCommentForEdit($id) {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$inline = $this->loadComment($id);
|
|
if (!$this->canEditInlineComment($user, $inline)) {
|
|
throw new Exception('That comment is not editable!');
|
|
}
|
|
return $inline;
|
|
}
|
|
|
|
private function canEditInlineComment(
|
|
PhabricatorUser $user,
|
|
PhabricatorAuditInlineComment $inline) {
|
|
|
|
// Only the author may edit a comment.
|
|
if ($inline->getAuthorPHID() != $user->getPHID()) {
|
|
return false;
|
|
}
|
|
|
|
// Saved comments may not be edited.
|
|
if ($inline->getAuditCommentID()) {
|
|
return false;
|
|
}
|
|
|
|
// Inline must be attached to the active revision.
|
|
if ($inline->getCommitPHID() != $this->commitPHID) {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
protected function deleteComment(PhabricatorInlineCommentInterface $inline) {
|
|
return $inline->delete();
|
|
}
|
|
|
|
protected function saveComment(PhabricatorInlineCommentInterface $inline) {
|
|
return $inline->save();
|
|
}
|
|
|
|
}
|