1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-28 06:29:27 +01:00
phorge-phorge/src/applications/differential/engine
epriestley 4b2a447003 Allow "has draft inlines?" queries to overheat
Summary:
Ref T13513. If your 10 most recently authored inlines have all been deleted, these queries can fail by overheating. This is silly and probably rarely happens outside of development.

For now, just let them overheat. This may create a false negative (incorrect "no draft" signal when the real condition is "drafts, but 10 most recent comments were deleted"). This could be sorted out later with a query mode like "executeAny()", perhaps.

Test Plan:
  - Created and deleted 10 inlines.
  - Submitted comments.
  - Before: overheating fatal during draft flag generation.
  - After: clean submission.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21274
2020-05-20 14:25:34 -07:00
..
DifferentialChangesetEngine.php For changesets that affect binaries, use the new binary file content hash as an effect hash 2020-04-27 08:34:55 -07:00
DifferentialDiffExtractionEngine.php Add "Revision has passing builds" Herald rules for commit content (pushes) and commits (discovery) 2019-05-01 10:02:47 -07:00
DifferentialFileTreeEngine.php Don't show the "file tree" view on tablets/phones 2020-04-23 13:40:42 -07:00
DifferentialRevisionDraftEngine.php Allow "has draft inlines?" queries to overheat 2020-05-20 14:25:34 -07:00
DifferentialRevisionTimelineEngine.php Remove "DifferentialInlineCommentQuery" 2020-05-07 16:07:55 -07:00