revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-27 14:09:11 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/project
History
Valerio Bozzolan 1aa532a476 Workboard Columns: avoid page reload on Edit > Cancel 
Summary:
The rationale for this change is that reloading a page unnecessarily wastes
resources that we can save.

This includes human resources (time) but also computational resources
as well. We probably save a fawn for every 1,000 clicks on that button.
A message to Greta Thunberg: now Phorge is with you.

This is the involved "Cancel" button, that does not reload the page anymore:

{F309894}

Closes T15471

Test Plan:
Workboard > Column > Edit > Cancel:

The popup closes gracefully instead of a page refresh.

Also try opening the workflow in another tab (/project/board/1/hide/2/) > Cancel:

You turn back to your Workboard just as before.

Reviewers: O1 Blessed Committers, Matthew

Reviewed By: O1 Blessed Committers, Matthew

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15471

Differential Revision: https://we.phorge.it/D25302
2023-07-28 19:02:40 +02:00
..
__tests__ Fix a PHP 8.1 unit test failure in Projects 2022-04-01 12:52:57 -07:00
application Make pressing "R" on your keyboard reload the card state on workboards 2019-07-17 13:11:26 -07:00
capability Add default View, Edit, and Join Policies to Projects 2014-11-21 11:22:17 -08:00
chart Make the top-level burndown chart in "Maniphest > Reports" show open tasks, not total tasks 2019-10-29 13:48:43 -07:00
command Implement a "!projects" mail command 2015-04-01 11:51:51 -07:00
conduit Migrate Project color to modular transactions 2017-05-18 16:46:06 -07:00
config Support subtypes in Projects 2019-01-30 06:17:55 -08:00
constants Allow workboard background colors to be configured 2016-02-16 08:15:12 -08:00
controller Workboard Columns: avoid page reload on Edit > Cancel 2023-07-28 19:02:40 +02:00
customfield Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
edge Replace subscribe/unsubscribe for projects with explicit mail setting 2016-01-19 19:39:02 -08:00
editor When predicting project membership during edits, predict milestones will have parent membership 2019-11-18 23:07:05 -08:00
engine Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project 2019-10-17 09:49:01 -07:00
engineextension Project Hovercards: Show Description 2023-07-05 13:31:55 -07:00
events On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
exception Hard code a "close task" action on every column Trigger 2019-03-25 13:21:55 -07:00
herald Add "Project tags added" and "Project tags removed" fields in Herald 2020-01-22 18:20:57 -08:00
icon Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
interface Fix a fatal in the "Projects" curtain extension when a project edge connects an object to a non-project 2019-10-17 09:49:01 -07:00
lipsum Migrate Project status to modular transactions 2017-05-18 11:36:13 -07:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
menuitem Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page when Reports prototype enabled 2023-05-08 14:35:22 +02:00
order Don't show workboard action previews if the action won't have any effect 2019-03-25 13:24:01 -07:00
phid PHP 8.1: fixes for strlen() not accepting NULL anymore, part 2 2023-04-01 15:20:13 +02:00
policyrule Add a "members of all projects" (vs "...any project") custom policy rule to the upstream 2018-06-12 11:51:51 -07:00
query Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
remarkup Fix spelling 2017-10-09 10:48:04 -07:00
search Support Ferret engine in Projects 2017-09-07 13:24:23 -07:00
searchfield Fix a bad call when prefilling ApplicationSearch from ?projects=some_slug 2016-02-08 10:44:33 -08:00
state Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page 2023-05-01 22:26:27 +02:00
storage Conduit column.search: add status, sequence and isDefault to API results 2023-06-19 08:58:52 +02:00
trigger Distinguish between "bad record format" and "bad record value" when validating Trigger rules 2019-04-17 12:40:55 -07:00
typeahead Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog 2023-05-20 17:48:53 +02:00
view Project Hovercards: Show Description 2023-07-05 13:31:55 -07:00
xaction Remove "PhabricatorFile->detachFromObject()" 2022-05-19 13:21:03 -07:00