1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/differential/view
epriestley 1da691113a Normalize the definition of "closed" revision statuses
Summary:
Currently, "Closed" and "Abandoned" are treated as "closed". I want to add a flag which treats "Accepted" as "Closed", too, for Asana and other companies who use an Asana-like workflow.

The background here is that their workflow is a bit weird. They basically do audits, but have a lot of things which Diffusion doesn't do well right now. This one change makes Differential fit their workflow fairly well, even though it's an audit workflow.

To prepare for this, normalize the definition of "closed" better. We have a few callsites which explicitly check for "ABANDONED || CLOSED", and normalizing this is cleaner anyway.

Also delete the very old COMMITTED status, which has been obsolete for over a year.

Test Plan: Browsed around most/all of the affected interfaces.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7653
2013-11-25 17:39:24 -08:00
..
DifferentialAddCommentView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialChangesetDetailView.php Fix lightbox downloads for embeded images and a warning 2013-10-17 11:21:01 -07:00
DifferentialChangesetFileTreeSideNavBuilder.php Merge branch 'master' into phutil_tag 2013-02-05 10:23:16 -08:00
DifferentialChangesetListView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialDiffTableOfContentsView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialInlineCommentEditView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialInlineCommentView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialLocalCommitsView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialPrimaryPaneView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
DifferentialResultsTableView.php render_tag -> tag: PropertyListView 2013-01-29 11:01:47 -08:00
DifferentialReviewersView.php CSS Tweaks to reviewers status list 2013-10-29 20:26:41 -07:00
DifferentialRevisionCommentListView.php Restore merge of phutil_tag. 2013-02-13 14:51:18 -08:00
DifferentialRevisionCommentView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialRevisionDetailView.php Add header icons to PHUIPropertyListView 2013-11-04 11:07:51 -08:00
DifferentialRevisionListView.php Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
DifferentialRevisionStatsView.php Remove line-related stats from Differential 2013-03-26 13:59:02 -07:00
DifferentialRevisionUpdateHistoryView.php Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00