1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/src
epriestley 0943561dcb Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects
Summary:
Fixes T13389. Currently, we try to "newSubtypeMap()" unconditionally, even if the underlying object does not support subtypes.

  - Only try to build a subtype map if subtype transactions are actually being applied.
  - When subtype transactions are applied to a non-subtypable object, fail more explicitly.

Test Plan: Clicked "Make Editable" in a fresh Calendar transaction form, got an editable form instead of a fatal from "newSubtypeMap()". (Calendar events are not currently subtypable.)

Maniphest Tasks: T13389

Differential Revision: https://secure.phabricator.com/D20741
2019-08-28 06:57:04 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Make minor flavor updates 2019-08-23 07:08:09 -07:00
applications Fix incorrect construction of subtype map when validating "subtype" transactions against non-subtypable objects 2019-08-28 06:57:04 -07:00
docs Remove "bin/accountadmin" and "scripts/user/add_user.php" 2019-08-20 17:58:20 -07:00
extensions
infrastructure When "utf8mb4" is available, use it as the default client charset when invoking standalone "mysql" commands 2019-08-27 16:36:48 -07:00
view Update Phortune payment account interfaces to handle merchant vs customer views 2019-08-22 21:02:41 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Give the Phortune external portal an order view 2019-08-26 07:49:17 -07:00