1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
phorge-phorge/scripts
epriestley 70fd96037b Consolidate user editing code
Summary:
  - We currently have some bugs in account creation due to nontransactional user/email editing.
    - We save $user, then try to save $email. This may fail for various reasons, commonly because the email isn't unique.
    - This leaves us with a $user with no email.
  - Also, logging of edits is somewhat inconsistent across various edit mechanisms.
  - Move all editing to a `PhabricatorUserEditor` class.
  - Handle some broken-data cases more gracefully.

Test Plan:
  - Created and edited a user with `accountadmin`.
  - Created a user with `add_user.php`
  - Created and edited a user with People editor.
  - Created a user with OAuth.
  - Edited user information via Settings.
  - Tried to create an OAuth user with a duplicate email address, got a proper error.
  - Tried to create a user via People with a duplicate email address, got a proper error.

Reviewers: btrahan, vrana, jungejason

Reviewed By: btrahan

CC: tberman, aran

Maniphest Tasks: T1184

Differential Revision: https://secure.phabricator.com/D2569
2012-05-25 07:30:44 -07:00
..
aphront Use PhabricatorEnv::newObjectFromConfig() wherever possible 2012-03-21 14:57:52 -07:00
calendar Display holidays 2012-05-03 09:22:52 -07:00
conduit Encode "<" and ">" in JSON/Ajax responses to prevent content-sniffing attacks 2012-02-14 14:51:51 -08:00
daemon Fix "phd repository-launch-readonly" 2012-05-10 20:27:55 -07:00
differential Ignore non-existing diffs in copied code detector script 2012-04-30 11:05:30 -07:00
drydock More Drydock Stuff 2012-03-26 20:54:26 -07:00
fpm Minify static resources 2012-03-28 10:13:53 -07:00
install Simplify daemon management: "phd start" 2012-05-09 10:29:37 -07:00
mail Provide upgrade script for transition away from Meta MTA daemon 2012-03-05 15:15:19 -08:00
repository Use one daemon to discover commits in all repositories, not one per repository 2012-05-08 12:53:41 -07:00
search Merge __init_env__.php into __init_script__.php 2011-10-02 11:48:09 -07:00
setup Test for pcntl availability from the command line, not Apache 2011-05-30 21:02:08 -07:00
sql Make default database namespace configurable 2012-04-30 11:56:58 -07:00
symbols Add an "--ignore-duplicates" flag to import_project_symbols.php 2012-04-07 17:25:38 -07:00
user Consolidate user editing code 2012-05-25 07:30:44 -07:00
util Add a script to programmatically add image macros 2012-03-09 08:55:11 -08:00
__init_script__.php Make SQL patch management DAG-based and provide namespace support 2012-04-30 07:54:00 -07:00
celerity_mapper.php Further improve unit/lint rendering 2012-05-01 10:15:56 -07:00