mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
09cdf0de48
Summary: Broadly, I'm trying to modernize these views and fix UI and at least mitigate mobile problems. See discussion. Test Plan: See screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7042
407 lines
11 KiB
PHP
407 lines
11 KiB
PHP
<?php
|
|
|
|
final class DiffusionBrowseController extends DiffusionController {
|
|
|
|
public function processRequest() {
|
|
$drequest = $this->diffusionRequest;
|
|
$is_file = false;
|
|
|
|
if ($this->getRequest()->getStr('before')) {
|
|
$is_file = true;
|
|
} else if ($this->getRequest()->getStr('grep') == '') {
|
|
$results = DiffusionBrowseResultSet::newFromConduit(
|
|
$this->callConduitWithDiffusionRequest(
|
|
'diffusion.browsequery',
|
|
array(
|
|
'path' => $drequest->getPath(),
|
|
'commit' => $drequest->getCommit(),
|
|
)));
|
|
$reason = $results->getReasonForEmptyResultSet();
|
|
$is_file = ($reason == DiffusionBrowseResultSet::REASON_IS_FILE);
|
|
}
|
|
|
|
if ($is_file) {
|
|
$controller = new DiffusionBrowseFileController($this->getRequest());
|
|
$controller->setDiffusionRequest($drequest);
|
|
$controller->setCurrentApplication($this->getCurrentApplication());
|
|
return $this->delegateToController($controller);
|
|
}
|
|
|
|
$content = array();
|
|
|
|
$content[] = $this->buildHeaderView($drequest);
|
|
$content[] = $this->buildActionView($drequest);
|
|
$content[] = $this->buildPropertyView($drequest);
|
|
|
|
$content[] = $this->renderSearchForm();
|
|
|
|
if ($this->getRequest()->getStr('grep') != '') {
|
|
$content[] = $this->renderSearchResults();
|
|
} else {
|
|
if (!$results->isValidResults()) {
|
|
$empty_result = new DiffusionEmptyResultView();
|
|
$empty_result->setDiffusionRequest($drequest);
|
|
$empty_result->setDiffusionBrowseResultSet($results);
|
|
$empty_result->setView($this->getRequest()->getStr('view'));
|
|
$content[] = $empty_result;
|
|
} else {
|
|
$phids = array();
|
|
foreach ($results->getPaths() as $result) {
|
|
$data = $result->getLastCommitData();
|
|
if ($data) {
|
|
if ($data->getCommitDetail('authorPHID')) {
|
|
$phids[$data->getCommitDetail('authorPHID')] = true;
|
|
}
|
|
}
|
|
}
|
|
|
|
$phids = array_keys($phids);
|
|
$handles = $this->loadViewerHandles($phids);
|
|
|
|
$browse_table = new DiffusionBrowseTableView();
|
|
$browse_table->setDiffusionRequest($drequest);
|
|
$browse_table->setHandles($handles);
|
|
$browse_table->setPaths($results->getPaths());
|
|
$browse_table->setUser($this->getRequest()->getUser());
|
|
|
|
$browse_panel = new AphrontPanelView();
|
|
$browse_panel->appendChild($browse_table);
|
|
$browse_panel->setNoBackground();
|
|
|
|
$content[] = $browse_panel;
|
|
}
|
|
|
|
$content[] = $this->buildOpenRevisions();
|
|
|
|
$readme = $this->callConduitWithDiffusionRequest(
|
|
'diffusion.readmequery',
|
|
array(
|
|
'paths' => $results->getPathDicts(),
|
|
));
|
|
if ($readme) {
|
|
$box = new PHUIBoxView();
|
|
$box->setShadow(true);
|
|
$box->appendChild($readme);
|
|
$box->addPadding(PHUI::PADDING_LARGE);
|
|
$box->addMargin(PHUI::MARGIN_LARGE);
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setHeader(pht('README'));
|
|
|
|
$content[] = array(
|
|
$header,
|
|
$box,
|
|
);
|
|
}
|
|
}
|
|
|
|
$crumbs = $this->buildCrumbs(
|
|
array(
|
|
'branch' => true,
|
|
'path' => true,
|
|
'view' => 'browse',
|
|
));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$content,
|
|
),
|
|
array(
|
|
'device' => true,
|
|
'title' => array(
|
|
nonempty(basename($drequest->getPath()), '/'),
|
|
$drequest->getRepository()->getCallsign().' Repository',
|
|
),
|
|
));
|
|
}
|
|
|
|
|
|
private function renderSearchForm() {
|
|
$drequest = $this->getDiffusionRequest();
|
|
$form = id(new AphrontFormView())
|
|
->setUser($this->getRequest()->getUser())
|
|
->setMethod('GET');
|
|
|
|
switch ($drequest->getRepository()->getVersionControlSystem()) {
|
|
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
|
|
$form->appendChild(pht('Search is not available in Subversion.'));
|
|
break;
|
|
|
|
default:
|
|
$form
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Search Here'))
|
|
->setName('grep')
|
|
->setValue($this->getRequest()->getStr('grep'))
|
|
->setCaption(pht('Enter a regular expression.')))
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue(pht('Search File Content')));
|
|
break;
|
|
}
|
|
|
|
$filter = new AphrontListFilterView();
|
|
$filter->appendChild($form);
|
|
|
|
if (!strlen($this->getRequest()->getStr('grep'))) {
|
|
$filter->setCollapsed(
|
|
pht('Show Search'),
|
|
pht('Hide Search'),
|
|
pht('Search for file content in this directory.'),
|
|
'#');
|
|
}
|
|
|
|
return $filter;
|
|
}
|
|
|
|
private function renderSearchResults() {
|
|
$drequest = $this->getDiffusionRequest();
|
|
$repository = $drequest->getRepository();
|
|
$results = array();
|
|
$no_data = pht('No results found.');
|
|
|
|
$limit = 100;
|
|
$page = $this->getRequest()->getInt('page', 0);
|
|
$pager = new AphrontPagerView();
|
|
$pager->setPageSize($limit);
|
|
$pager->setOffset($page);
|
|
$pager->setURI($this->getRequest()->getRequestURI(), 'page');
|
|
|
|
try {
|
|
|
|
$results = $this->callConduitWithDiffusionRequest(
|
|
'diffusion.searchquery',
|
|
array(
|
|
'grep' => $this->getRequest()->getStr('grep'),
|
|
'stableCommitName' => $drequest->getStableCommitName(),
|
|
'path' => $drequest->getPath(),
|
|
'limit' => $limit + 1,
|
|
'offset' => $page));
|
|
|
|
} catch (ConduitException $ex) {
|
|
$err = $ex->getErrorDescription();
|
|
if ($err != '') {
|
|
return id(new AphrontErrorView())
|
|
->setTitle(pht('Search Error'))
|
|
->appendChild($err);
|
|
}
|
|
}
|
|
|
|
$results = $pager->sliceResults($results);
|
|
|
|
require_celerity_resource('syntax-highlighting-css');
|
|
|
|
// NOTE: This can be wrong because we may find the string inside the
|
|
// comment. But it's correct in most cases and highlighting the whole file
|
|
// would be too expensive.
|
|
$futures = array();
|
|
$engine = PhabricatorSyntaxHighlighter::newEngine();
|
|
foreach ($results as $result) {
|
|
list($path, $line, $string) = $result;
|
|
$futures["{$path}:{$line}"] = $engine->getHighlightFuture(
|
|
$engine->getLanguageFromFilename($path),
|
|
ltrim($string));
|
|
}
|
|
|
|
try {
|
|
Futures($futures)->limit(8)->resolveAll();
|
|
} catch (PhutilSyntaxHighlighterException $ex) {
|
|
}
|
|
|
|
$rows = array();
|
|
foreach ($results as $result) {
|
|
list($path, $line, $string) = $result;
|
|
|
|
$href = $drequest->generateURI(array(
|
|
'action' => 'browse',
|
|
'path' => $path,
|
|
'line' => $line,
|
|
));
|
|
|
|
try {
|
|
$string = $futures["{$path}:{$line}"]->resolve();
|
|
} catch (PhutilSyntaxHighlighterException $ex) {
|
|
}
|
|
|
|
$string = phutil_tag(
|
|
'pre',
|
|
array('class' => 'PhabricatorMonospaced'),
|
|
$string);
|
|
|
|
$path = Filesystem::readablePath($path, $drequest->getPath());
|
|
|
|
$rows[] = array(
|
|
phutil_tag('a', array('href' => $href), $path),
|
|
$line,
|
|
$string,
|
|
);
|
|
}
|
|
|
|
$table = id(new AphrontTableView($rows))
|
|
->setClassName('remarkup-code')
|
|
->setHeaders(array(pht('Path'), pht('Line'), pht('String')))
|
|
->setColumnClasses(array('', 'n', 'wide'))
|
|
->setNoDataString($no_data);
|
|
|
|
return id(new AphrontPanelView())
|
|
->setNoBackground(true)
|
|
->appendChild($table)
|
|
->appendChild($pager);
|
|
}
|
|
|
|
|
|
private function markupText($text) {
|
|
$engine = PhabricatorMarkupEngine::newDiffusionMarkupEngine();
|
|
$engine->setConfig('viewer', $this->getRequest()->getUser());
|
|
$text = $engine->markupText($text);
|
|
|
|
$text = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-remarkup',
|
|
),
|
|
$text);
|
|
|
|
return $text;
|
|
}
|
|
|
|
private function buildHeaderView(DiffusionRequest $drequest) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setUser($viewer)
|
|
->setHeader($this->renderPathLinks($drequest))
|
|
->setPolicyObject($drequest->getRepository());
|
|
|
|
return $header;
|
|
}
|
|
|
|
private function buildActionView(DiffusionRequest $drequest) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$view = id(new PhabricatorActionListView())
|
|
->setUser($viewer);
|
|
|
|
$history_uri = $drequest->generateURI(
|
|
array(
|
|
'action' => 'history',
|
|
));
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('View History'))
|
|
->setHref($history_uri)
|
|
->setIcon('perflab'));
|
|
|
|
$behind_head = $drequest->getRawCommit();
|
|
$head_uri = $drequest->generateURI(
|
|
array(
|
|
'commit' => '',
|
|
'action' => 'browse',
|
|
));
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Jump to HEAD'))
|
|
->setHref($head_uri)
|
|
->setIcon('home')
|
|
->setDisabled(!$behind_head));
|
|
|
|
// TODO: Ideally, this should live in Owners and be event-triggered, but
|
|
// there's no reasonable object for it to react to right now.
|
|
|
|
$owners_uri = id(new PhutilURI('/owners/view/search/'))
|
|
->setQueryParams(
|
|
array(
|
|
'repository' => $drequest->getCallsign(),
|
|
'path' => '/'.$drequest->getPath(),
|
|
));
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Find Owners'))
|
|
->setHref((string)$owners_uri)
|
|
->setIcon('preview'));
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function buildPropertyView(DiffusionRequest $drequest) {
|
|
$viewer = $this->getRequest()->getUser();
|
|
|
|
$view = id(new PhabricatorPropertyListView())
|
|
->setUser($viewer);
|
|
|
|
$stable_commit = $drequest->getStableCommitName();
|
|
$callsign = $drequest->getRepository()->getCallsign();
|
|
|
|
$view->addProperty(
|
|
pht('Commit'),
|
|
phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $drequest->generateURI(
|
|
array(
|
|
'action' => 'commit',
|
|
'commit' => $stable_commit,
|
|
)),
|
|
),
|
|
$drequest->getRepository()->formatCommitName($stable_commit)));
|
|
|
|
if ($drequest->getTagContent()) {
|
|
$view->addProperty(
|
|
pht('Tag'),
|
|
$drequest->getSymbolicCommit());
|
|
|
|
$view->addSectionHeader(pht('Tag Content'));
|
|
$view->addTextContent($this->markupText($drequest->getTagContent()));
|
|
}
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function renderPathLinks(DiffusionRequest $drequest) {
|
|
$path = $drequest->getPath();
|
|
$path_parts = array_filter(explode('/', trim($path, '/')));
|
|
|
|
$links = array();
|
|
if ($path_parts) {
|
|
$links[] = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $drequest->generateURI(
|
|
array(
|
|
'action' => 'browse',
|
|
'path' => '',
|
|
)),
|
|
),
|
|
'r'.$drequest->getRepository()->getCallsign().'/');
|
|
$accum = '';
|
|
$last_key = last_key($path_parts);
|
|
foreach ($path_parts as $key => $part) {
|
|
$links[] = ' ';
|
|
$accum .= '/'.$part;
|
|
if ($key === $last_key) {
|
|
$links[] = $part;
|
|
} else {
|
|
$links[] = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $drequest->generateURI(
|
|
array(
|
|
'action' => 'browse',
|
|
'path' => $accum,
|
|
)),
|
|
),
|
|
$part.'/');
|
|
}
|
|
}
|
|
} else {
|
|
$links[] = 'r'.$drequest->getRepository()->getCallsign().'/';
|
|
}
|
|
|
|
return $links;
|
|
}
|
|
|
|
}
|